CompatHelper: bump compat for SpecialFunctions to 2, (keep existing compat) #10
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -23,7 +23,7 @@ FourierTools = "0.2.1" | |||
| IndexFunArrays = "0.2" | |||
| Interpolations = "0.12, 0.13" | |||
| QuadGK = "2.4.1" | |||
| SpecialFunctions = "1, 1.1, 1.2" | |||
| SpecialFunctions = "1, 1.1, 1.2, 2" | |||
There was a problem hiding this comment.
Why there was 1, 1.1, 1.2? That's equivalent to just 1
There was a problem hiding this comment.
Probably because I didn't know what I was doing :D
Or maybe compat helper merged this?
There was a problem hiding this comment.
CompatHelper wouldn't do that since these aren't different major versions. For the record 9538ef1
There was a problem hiding this comment.
Also, why is SpecialFunctions both in the main deps and in the extras? That's useless
There was a problem hiding this comment.
Thanks for pointing that out.
I try to fix that once I have time re-designing the general implementation.
There was a problem hiding this comment.
Wait, doesn't SpecialFunctions need to be mentioned in extras when I need it for testing purpose as well?
This pull request changes the compat entry for the
SpecialFunctionspackage from1, 1.1, 1.2to1, 1.1, 1.2, 2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.