Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompatHelper: bump compat for SpecialFunctions to 2, (keep existing compat) #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CompatHelper: bump compat for SpecialFunctions to 2, (keep existing compat) #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ FourierTools = "0.2.1"
IndexFunArrays = "0.2"
Interpolations = "0.12, 0.13"
QuadGK = "2.4.1"
SpecialFunctions = "1, 1.1, 1.2"
SpecialFunctions = "1, 1.1, 1.2, 2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there was 1, 1.1, 1.2? That's equivalent to just 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because I didn't know what I was doing :D
Or maybe compat helper merged this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CompatHelper wouldn't do that since these aren't different major versions. For the record 9538ef1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why is SpecialFunctions both in the main deps and in the extras? That's useless

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out.
I try to fix that once I have time re-designing the general implementation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, doesn't SpecialFunctions need to be mentioned in extras when I need it for testing purpose as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

Zygote = "0.6"
julia = "1.6"

Expand Down