Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style updates for new donation thank-you page #298

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

sjwmoveon
Copy link
Contributor

Goes with changes in ak-template-set

@@ -17,6 +17,10 @@ form {

box-shadow: none;

.hidden {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an existing class called d-none on the donation thank you pages with the same CSS property?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that, but I do see .hide, with the same property (in /pages/_donate_thanks.css:42. It might be better to move this definition higher in the css and unify it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! I think what happened was I forgot to clean out the branch from the unsubscribe changes, and so those commits got put into the new pull request. I removed the ".hidden" style since it's not necessary.

@@ -17,6 +17,10 @@ form {

box-shadow: none;

.hidden {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that, but I do see .hide, with the same property (in /pages/_donate_thanks.css:42. It might be better to move this definition higher in the css and unify it.

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants