-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style updates for new donation thank-you page #298
base: main
Are you sure you want to change the base?
Conversation
src/styles/components/_form.scss
Outdated
@@ -17,6 +17,10 @@ form { | |||
|
|||
box-shadow: none; | |||
|
|||
.hidden { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an existing class called d-none
on the donation thank you pages with the same CSS property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see that, but I do see .hide
, with the same property (in /pages/_donate_thanks.css:42
. It might be better to move this definition higher in the css and unify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! I think what happened was I forgot to clean out the branch from the unsubscribe changes, and so those commits got put into the new pull request. I removed the ".hidden" style since it's not necessary.
src/styles/components/_form.scss
Outdated
@@ -17,6 +17,10 @@ form { | |||
|
|||
box-shadow: none; | |||
|
|||
.hidden { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see that, but I do see .hide
, with the same property (in /pages/_donate_thanks.css:42
. It might be better to move this definition higher in the css and unify it.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Goes with changes in ak-template-set