-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style updates for new donation thank-you page #298
Open
sjwmoveon
wants to merge
10
commits into
main
Choose a base branch
from
sophie-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7f50e7f
Add "hidden" class for form elements
sjwmoveon 397ba8b
Really hide element
sjwmoveon 15d4aa5
Style updates for new donation thank-you page
sjwmoveon 9f71522
Remove unused 'hidden' style
sjwmoveon 9b619de
Fix padding on "Copy URL" button
sjwmoveon 6e4b0a0
Add custom CTA button background color
sjwmoveon 5e2926b
Merge branch 'main' of github.com:MoveOnOrg/giraffe
sjwmoveon ebe7f70
More formatting tweaks
sjwmoveon b6edbd9
Increase legal footer to 20px
sjwmoveon 8db8180
Make icon and text color change simultaneous on hover
sjwmoveon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an existing class called
d-none
on the donation thank you pages with the same CSS property?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see that, but I do see
.hide
, with the same property (in/pages/_donate_thanks.css:42
. It might be better to move this definition higher in the css and unify it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! I think what happened was I forgot to clean out the branch from the unsubscribe changes, and so those commits got put into the new pull request. I removed the ".hidden" style since it's not necessary.