Deleting HPA object does not reduce replicas down (#145)

Signed-off-by: Vishesh Tanksale <[email protected]>
NVIDIA · Sep 19, 2024 · 901820a · 901820a
1 parent bf90441
commit 901820a
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 0 deletions.
diff --git a/api/apps/v1alpha1/nimservice_types.go b/api/apps/v1alpha1/nimservice_types.go
@@ -77,6 +77,7 @@ type NIMServiceSpec struct {
 	Scale          Autoscaling                  `json:"scale,omitempty"`
 	Metrics        Metrics                      `json:"metrics,omitempty"`
 	// +kubebuilder:validation:Minimum=1
+	// +kubebuilder:default:=1
 	Replicas int    `json:"replicas,omitempty"`
 	UserID   *int64 `json:"userID,omitempty"`
 	GroupID  *int64 `json:"groupID,omitempty"`

diff --git a/bundle/manifests/apps.nvidia.com_nimpipelines.yaml b/bundle/manifests/apps.nvidia.com_nimpipelines.yaml
@@ -1272,6 +1272,7 @@ spec:
                               type: object
                           type: object
                         replicas:
+                          default: 1
                           minimum: 1
                           type: integer
                         resources:

diff --git a/bundle/manifests/apps.nvidia.com_nimservices.yaml b/bundle/manifests/apps.nvidia.com_nimservices.yaml
@@ -1212,6 +1212,7 @@ spec:
                     type: object
                 type: object
               replicas:
+                default: 1
                 minimum: 1
                 type: integer
               resources:

diff --git a/config/crd/bases/apps.nvidia.com_nimpipelines.yaml b/config/crd/bases/apps.nvidia.com_nimpipelines.yaml
@@ -1272,6 +1272,7 @@ spec:
                               type: object
                           type: object
                         replicas:
+                          default: 1
                           minimum: 1
                           type: integer
                         resources:

diff --git a/config/crd/bases/apps.nvidia.com_nimservices.yaml b/config/crd/bases/apps.nvidia.com_nimservices.yaml
@@ -1212,6 +1212,7 @@ spec:
                     type: object
                 type: object
               replicas:
+                default: 1
                 minimum: 1
                 type: integer
               resources:

diff --git a/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimpipelines.yaml b/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimpipelines.yaml
@@ -1272,6 +1272,7 @@ spec:
                               type: object
                           type: object
                         replicas:
+                          default: 1
                           minimum: 1
                           type: integer
                         resources:

diff --git a/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimservices.yaml b/deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimservices.yaml
@@ -1212,6 +1212,7 @@ spec:
                     type: object
                 type: object
               replicas:
+                default: 1
                 minimum: 1
                 type: integer
               resources: