[13.0] [MIG] fieldservice_sale #595

brian10048 · 2020-07-18T04:18:42Z

Migration of fieldservice_sale to 13.0

Depends on #598

OCA-git-bot · 2020-07-18T05:44:46Z

Hi @max3903, @wolfhall,
some modules you are maintaining are being modified, check this out!

RLeeOSI

FSM territory was moved to base_territory, fixes error on res.config.settings.execute() with too many positional arguments

fieldservice_sale/__manifest__.py

fieldservice_sale/models/__init__.py

fieldservice_sale/models/fsm_branch.py

fieldservice_sale/views/fsm_branch.xml

fieldservice_sale/models/fsm_location.py

fieldservice_sale/views/res_config_settings.xml

brian10048 · 2020-10-06T00:00:55Z

@RLeeOSI Thank you!

bodedra · 2020-10-22T18:52:13Z

@brian10048 Would you please run "pre-commit run -a" # to run black, isort and prettier (ignore pylint errors at this stage)

brian10048 · 2020-10-22T20:30:09Z

@brian10048 Would you please run "pre-commit run -a" # to run black, isort and prettier (ignore pylint errors at this stage)

@bodedra Done, but will still need #598 before the build is green here

hparfr · 2020-11-10T16:13:05Z

fieldservice_sale/README.rst

+
+* Serpent Consulting Services Pvt. Ltd. <[email protected]>
+* Brian McMaster <[email protected]>
+* Rapha??l Reverdy <[email protected]>


there is an encoding issue

there is also issues in po files.

osi-scampbell · 2020-11-10T23:01:59Z

@brian10048 Hey Brian, the migration looks really good! I found a small bug in v12 that I have fixed here #668. The changes are small and easy and I was hoping you could implement these in this PR so we don't have this bug in v13. Thanks!

hparfr

I may be miss something, but I think the logic about invoicing is not aligned with other parts of odoo (like sale_stock).

hparfr · 2020-11-11T17:21:53Z

fieldservice_sale/tests/test_fsm_sale_order.py

+        """Test sale order 3 flow from sale to invoice.
+        - An FSM order should be created for each Sale Order Line.
+        - The FSM Order should update qty_delivered when completed.
+        - An Invoice linked to each FSM Order should be created.


I don't get this.

All fsm orders shoudn't be in the same invoice ?

Ping @wolfhall @max3903

Asked @osi-scampbell about this one. Some SOs will trigger creation of multiple FSOs. One (or more) of those FSOs can include labor that wasn't included on the original SO. Therefore, it creates its own invoice for those lines not included on the original SO. This is an intended feature

Yes, it is an intended feature. However, I don't prefer it for my usage.

Does anyone have suggestions for how we can accomplish both ways? Maybe a setting in the configuration panel that will either split invoices or keep them as one?

My thoughts exactly. It would be nice to add a feature that allows a choice between the existing functionality (each FSO generates an invoice) and consolidating invoices for all FSOs created from the same SO. But that's not really part of migration, it's a new feature. I'm not familiar with OCA best practices in this case, but IMO it's best to leave new features separate from the migration PR

Yes agreed @RLeeOSI New feature will not be part of migration. To introduce new feature, create a issue, represent blueprint and submit PR.

One (or more) of those FSOs can include labor that wasn't included on the original SO. Therefore, it creates its own invoice for those lines not included on the original SO. This is an intended feature

I think it can be implemented with existing modules:
You can add sale order line with a product.type=service (labor) automatically when adding a product.type=fsm thanks to product-pack ( https://github.com/oca/product-pack ) or with more advanced settings ( https://github.com/akretion/sale-configurator ).
You can then track the progression of service with timesheets. It will be more aligned with other parts of odoo (stock, mrp).

Even if this proposition do not work for your use case, are you really sure this feature need to be included in fieldservice_sale and not in his own module ?
May be I'm wrong, but from point of view this feature is too specific to be included in fieldservice_sale. It can be easily extracted in another module, and letting it in fieldservice_sale adds complexity like now during a migration.

But that's not really part of migration, it's a new feature.

Let's say it's part of a migration cleanup/refactoring. Doing it now is may be the best moment to introduce breaking change like dependency graph and modules organization.

@hparfr I am good with migration cleanup/refactoring. But can you provide it with migration script and unit test?

…raint (#2)

hparfr

LGTM !

Thanks

brian10048 · 2021-06-04T13:46:29Z

@bodedra @RLeeOSI are either of you available to review this migration?

RLeeOSI · 2021-07-03T01:15:31Z

@brian10048 Was the invoice creation part completely removed? It looks like now there will be no link between the FSO and the invoice. Has that been moved to another module?

I recommend adding another selection field to product.template similar to field_service_tracking, that allows the user to choose whether the SO generates a single invoice, or one invoice per FSO.

Chanakya-OSI · 2021-09-16T13:24:41Z

@brian10048 I want to add Migration Script in the fieldservice_sale module in V13 so can you please add me as a collaborator? Thanks

brian10048 · 2021-09-16T13:41:16Z

@Chanakya-OSI You should be able to submit a PR to my branch here. If everything looks good we can then merge this PR with your commits as well

dreispt · 2021-12-04T18:30:30Z

/ocabot merge nobump

OCA-git-bot · 2021-12-04T18:30:40Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-595-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

brian10048 · 2022-03-09T18:59:19Z

/ocabot merge nobump

OCA-git-bot · 2022-03-09T18:59:42Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-595-by-brian10048-bump-nobump, awaiting test results.

OCA-git-bot · 2022-03-09T19:19:50Z

Congratulations, your PR was merged at 6b29dfe. Thanks a lot for contributing to OCA. ❤️

brian10048 added needs review migration labels Jul 18, 2020

brian10048 added this to the 13.0 milestone Jul 18, 2020

brian10048 requested review from max3903, marcelsavegnago, nelsonramirezs and bodedra July 18, 2020 04:18

brian10048 self-assigned this Jul 18, 2020

OCA-git-bot mentioned this pull request Jul 18, 2020

Migration to version 13.0 #354

Open

43 tasks

brian10048 linked an issue Jul 18, 2020 that may be closed by this pull request

Migration to version 13.0 #354

Open

43 tasks

brian10048 force-pushed the 13.0-mig-fsm-sale branch from a214be4 to 5c81a70 Compare July 18, 2020 04:34

brian10048 mentioned this pull request Jul 20, 2020

[13.0] [MIG] fieldservice_sale_recurring #597

Merged

brian10048 force-pushed the 13.0-mig-fsm-sale branch 5 times, most recently from 67fc2f3 to 8d77aa2 Compare July 21, 2020 19:03

brian10048 mentioned this pull request Aug 2, 2020

13.0 #610

Closed

RLeeOSI suggested changes Oct 5, 2020

View reviewed changes

RLeeOSI mentioned this pull request Oct 5, 2020

[FIX] fieldservice_sale migration changes brian10048/field-service#13

Merged

brian10048 added the Blocked by dependency label Oct 16, 2020

brian10048 force-pushed the 13.0-mig-fsm-sale branch 2 times, most recently from 5f603f9 to 8839733 Compare October 22, 2020 20:28

hparfr requested changes Nov 10, 2020

View reviewed changes

hparfr requested changes Nov 11, 2020

View reviewed changes

brian10048 and others added 8 commits April 26, 2021 12:05

[MIG] fieldservice_sale: Migration to 13.0

b8b95bb

[FIX] fieldservice_sale migration changes

a82aff5

[FIX] invoice creation from SO

5d9084e

[IMP] pre-commit, black

547bbd1

fieldservice_sale Fix invoicing in v13

1f3b760

fieldservice_sale: fix fsm_order only on services

f182ad1

fielservice_sale fix link with invoices

3d1c19d

[FIX] ERROR: null value in column location_id violates not-null const…

6c868a8

…raint (#2)

brian10048 force-pushed the 13.0-mig-fsm-sale branch from 06f3a88 to 6c868a8 Compare April 26, 2021 16:06

[IMP] pre-commit, prettier

358124e

hparfr approved these changes Apr 26, 2021

View reviewed changes

dreispt requested a review from RLeeOSI May 8, 2021 21:54

brian10048 requested review from murtuzasaleh and smangukiya June 4, 2021 13:47

[13.0][ADD] Migrations Script:fieldservice_sale.

8b329cb

brian10048 requested a review from Chanakya-OSI September 23, 2021 16:35

OCA-git-bot added a commit that referenced this pull request Dec 4, 2021

Merge PR #595 into 13.0

fd46e4d

Signed-off-by dreispt

OCA-git-bot added the bot is merging ⏳ label Dec 4, 2021

OCA-git-bot merged commit d30e607 into OCA:13.0 Mar 9, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0] [MIG] fieldservice_sale #595

[13.0] [MIG] fieldservice_sale #595

brian10048 commented Jul 18, 2020 •

edited

Loading

OCA-git-bot commented Jul 18, 2020

RLeeOSI left a comment

brian10048 commented Oct 6, 2020

bodedra commented Oct 22, 2020

brian10048 commented Oct 22, 2020

hparfr Nov 10, 2020

osi-scampbell commented Nov 10, 2020

hparfr left a comment

hparfr Nov 11, 2020

bodedra Nov 17, 2020

RLeeOSI Nov 17, 2020

brian10048 Nov 17, 2020

RLeeOSI Nov 17, 2020

bodedra Nov 17, 2020

hparfr Nov 19, 2020 •

edited

Loading

bodedra Nov 25, 2020

hparfr left a comment

brian10048 commented Jun 4, 2021

RLeeOSI commented Jul 3, 2021

Chanakya-OSI commented Sep 16, 2021

brian10048 commented Sep 16, 2021

dreispt commented Dec 4, 2021

OCA-git-bot commented Dec 4, 2021

brian10048 commented Mar 9, 2022

OCA-git-bot commented Mar 9, 2022

OCA-git-bot commented Mar 9, 2022

[13.0] [MIG] fieldservice_sale #595

[13.0] [MIG] fieldservice_sale #595

Conversation

brian10048 commented Jul 18, 2020 • edited Loading

OCA-git-bot commented Jul 18, 2020

RLeeOSI left a comment

Choose a reason for hiding this comment

brian10048 commented Oct 6, 2020

bodedra commented Oct 22, 2020

brian10048 commented Oct 22, 2020

Choose a reason for hiding this comment

osi-scampbell commented Nov 10, 2020

hparfr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hparfr Nov 19, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hparfr left a comment

Choose a reason for hiding this comment

brian10048 commented Jun 4, 2021

RLeeOSI commented Jul 3, 2021

Chanakya-OSI commented Sep 16, 2021

brian10048 commented Sep 16, 2021

dreispt commented Dec 4, 2021

OCA-git-bot commented Dec 4, 2021

brian10048 commented Mar 9, 2022

OCA-git-bot commented Mar 9, 2022

OCA-git-bot commented Mar 9, 2022

brian10048 commented Jul 18, 2020 •

edited

Loading

hparfr Nov 19, 2020 •

edited

Loading