[16.0][MIG] base_tier_validation_correction #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosd
suggested changes
Nov 29, 2023
| self.assertFalse(doc_user2.can_review) | ||
| # User 1, is the reviewer as specified in the tier.definition | ||
| doc_user1 = self.test_record.with_user(self.test_user_1.id) | ||
| doc_user1._invalidate_cache() |
There was a problem hiding this comment.
Suggested change
| doc_user1._invalidate_cache() | |
| doc_user1.invalidate_recordset() |
invalidate_cache() is deprecated.
Please change this here, among with the other places it occurs in this file
| self.assertTrue(doc_user2.can_review) | ||
| doc_user1._invalidate_cache() | ||
| self.assertFalse(doc_user1.can_review) | ||
| # Make reversion, now user 1 can reivew |
There was a problem hiding this comment.
Suggested change
| # Make reversion, now user 1 can reivew | |
| # Make reversion, now user 1 can review |
|
@ChrisOForgeFlow Can you attend to this? 🙏 |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Can we reopen and try to get it merged? |
|
@ForgeFlow Can you attend to my comments? |
AlexPForgeFlow
force-pushed
the
16.0-mig-base_tier_validation_correction
branch
from
10b8fbf to
740df60
Compare
|
Hi @bosd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ForgeFlow