-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to PureScript 0.15 #1521
Conversation
1. use esm imports 2. do not re-export `Undefined` from `Contract.Prelude` 3. fix CIP-30 mock, use `global` object in Node.js environment
c56e135
to
88d2150
Compare
88d2150
to
fe138b0
Compare
ae88ea6
to
70e3356
Compare
The last remaining issue we're tracking down is https://hercules-ci.com/accounts/github/Plutonomicon/derivations/%2Fnix%2Fstore%2Ffhn3q2yjdl6jq5m0lqcfpj4ld5lyrzlz-ctl-plutip-test.drv/log?via-job=d200f417-2c25-447d-bbff-2e0de43828f3 Which is the build result of #1573 |
…n/cardano-transaction-lib into dshuiski/purs-0.15-migration
@bladyjoker I've seen this same error in #1566, after debugging plutip cardano-node, I found an error which was being caused by a wrong cardano-api version in plutip, that's why I created mlabs-haskell/plutip#184 |
This is an heroic effort and I appreciate it. |
@klarkc we managed to get everything working centered around cardano-node v8.1.1. Moving to v8.5 will have to be a battle for some other day. Can you summarize the work you did across CTL and Plutip and whether your efforts for 8.5 migration resulted in passing tests or were there some lingering issues? |
…n/cardano-transaction-lib into dshuiski/purs-0.15-migration
@bladyjoker I've bump cardano-api constraint to ^>= 8.25 (as in cardano-node 8.5) in order to fix request plutip errors, the last time I checked, we're being blocked by plutip -> cardano-wallet. We still need a valid build plan for plutip with cardano-wallet. |
Building searchable documentation fails. Not merging yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to click this button after all this work :)
BTW, congratulations to everyone on achieving it. It will really help us here. |
Closes #79
Closes #1430
purs
tov0.15.8
spago
tov0.21.0
purescript-math
dependencyMonadZero
type classmedea-ps
to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/medea-ps#1sequences
dependency Dropsequences
dependency mlabs-haskell/purescript-aeson#18purescript-bignumber
to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/purescript-bignumber#3purescript-aeson
to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/purescript-aeson#17noble-secp256k1
to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/purescript-noble-secp256k1#3toppokki
to PureScript 0.15 Migrate to PureScript 0.15 mlabs-haskell/purescript-toppokki#1cjs
exports toesm
using lebab, replaceexport var
withexport const
EncodeAeson
andDecodeAeson
instances forCtl.Internal.Plutus.Types.AssocMap
ToMetadata
instance for(NonEmpty f a)
TODO: Can it be rewritten instead?AffjaxDriver
depending on the environment (node or browser)SProxy
with kind-genericProxy
ToData
/FromData
instances forCtl.Internal.Types.Interval.Extended
andTest.Data.Tree
Test.QuickCheck.Gen.frequency
withNonEmptyArray
exists
fromNode.FS.Sync
(Node.FS.Aff.exists
has been removed)esm
importsUndefined
fromContract.Prelude
(removeundefined
dependency fromspago.dhall
)global
object in Node.js environmentesbuild
node_modules
symlinks toNODE_PATH
(see NODE_PATH is not part of resolving import specifiers)bundlePursProject
now usesesbuild
)webpack
@mlabs-haskell/csl-gc-wrapper
Pre-review checklist
make format
)## Unreleased
header, using the appropriate sub-headings (### Added
,### Removed
,### Fixed
), and the links to the appropriate issues/PRs have been included