Creates ConcurrencyOptions pydantic model.
#15291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #15291 will not alter performanceComparing Summary
|
jeanluciano
requested review from
discdiver,
cicdw,
desertaxle and
zzstoatzz
as code owners
…mit enforcement prior to attempting to acquire a slot.
…onsistent with other prefect-nomenclature.
…e more consistent with other prefect-nomenclature." This reverts commit 0a4940f.
…dle attempting to acquire a slot from a deploy gcl that doesn't exist.
…' of https://github.com/PrefectHQ/prefect into jean/oss-66-create-a-concurrency-options-pydantic-model
…' of https://github.com/PrefectHQ/prefect into jean/oss-66-create-a-concurrency-options-pydantic-model
desertaxle
requested changes
Sep 13, 2024
desertaxle
requested changes
Sep 16, 2024
…' of https://github.com/PrefectHQ/prefect into jean/oss-66-create-a-concurrency-options-pydantic-model
…' of https://github.com/PrefectHQ/prefect into jean/oss-66-create-a-concurrency-options-pydantic-model
desertaxle
approved these changes
Sep 17, 2024
jeanluciano
deleted the
jean/oss-66-create-a-concurrency-options-pydantic-model
branch
collincchoy
reviewed
Sep 18, 2024
| @@ -878,7 +878,18 @@ def job_variables(self): | |||
| ) | |||
|
|
|||
| concurrency_limit: Mapped[Union[int, None]] = mapped_column( | |||
| sa.Integer, default=None, nullable=True | |||
| sa.Integer, | |||
| server_default=None, | |||
There was a problem hiding this comment.
did this server default get added w/o a db migration?
or well - why did this get added?
There was a problem hiding this comment.
Oh. TIL alembic doesn't pick up server_default changes by default so I guess this doesn't matter but I think this line isn't doing anything as the DDL has already been generated and the updated DDL to alter the column w/ a db-server-side default isn't tracked via migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two pydantic models
ConcurrencyLimitConfig,ConcurrencyOptions, and updatesDeployment.concurrency_limitto be able to useConcurrencyLimitConfig. Also adds a concurrecy_options column to the deployments table.Related: #14934, #15340
Checklist
<link to issue>"mint.json.