Set DateTimeFormatter pattern to null by default #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@voronkovich I cannot reproduce that the formatter returns an empty string when Also, the PHP documentation indicates that an empty string should be the default value: http://php.net/manual/en/intldateformatter.create.php Could you post an example? What other options did you set on the |
|
@sandermarechal, there was a strange bug in my code. Sorry for confusing you! So, closing this PR. |
|
Ok, thanks for clearing that up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeFormatter returns an empty string when
''set as a pattern.