Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Drake to latest release 1.20.0 #294

Merged

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Aug 15, 2023

Closes #296.

See also #293.


This change is Reviewable

@jwnimmer-tri
Copy link
Contributor Author

+@EricCousineau-TRI for review, please.

Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, thanks! \cc @IanTheEngineer @calderpg-tri

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Contributor Author

I think the one of the builds keeps timing out. I'm not sure if I should keep retrying it, but I'll give it another go.

@EricCousineau-TRI
Copy link
Collaborator

EricCousineau-TRI commented Aug 16, 2023

I've filed #295 to try and fix the caching issues as you've mentioned a ways back.
I will test locally using ./run_all_tests.sh, and then force merge if that works out.

@jwnimmer-tri
Copy link
Contributor Author

We'll probably have Drake v1.20 tagged before CI is ready here, in which case I'll plan to rework this to pin v1.20 instead.

@jwnimmer-tri
Copy link
Contributor Author

Hah, our posts crossed in the wind.

I guess I don't mind whether we land this with 1.19 now or wait a couple hours for 1.20.

@EricCousineau-TRI
Copy link
Collaborator

EricCousineau-TRI commented Aug 16, 2023

Ah, probably good to just wait out v1.20.0. I'll let my local tests continue to run, just in case.

EDIT: Tests pass locally.

@jwnimmer-tri jwnimmer-tri changed the title Upgrade Drake to latest release 1.19.0 Upgrade Drake to latest release 1.20.0 Aug 16, 2023
@jwnimmer-tri
Copy link
Contributor Author

Pushed up to 1.20 now.

@EricCousineau-TRI
Copy link
Collaborator

Local testing passed w/ newer v1.20.0 push - merging!

@EricCousineau-TRI EricCousineau-TRI merged commit 1d59967 into RobotLocomotion:main Aug 18, 2023
6 of 7 checks passed
@jwnimmer-tri jwnimmer-tri deleted the drake-commit-bump branch August 18, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update DRAKE_SUGGESTED_VERSION to v1.20.0
2 participants