Merge pull request #39 from SalesforceFoundation/feature/settings-str…

…ing-review Feature/settings string review
SalesforceFoundation · May 19, 2016 · 0b7a80f · 0b7a80f
2 parents e4d4b3c + f9cfdcc
commit 0b7a80f
Show file tree

Hide file tree

Showing 20 changed files with 22 additions and 62 deletions.
diff --git a/cumulusci.properties b/cumulusci.properties
@@ -1,6 +1,6 @@
 cumulusci.package.name=Recurring Donations
 cumulusci.package.namespace=npe03
-cumulusci.package.apiVersion=29.0
+cumulusci.package.apiVersion=36.0
 cumulusci.package.installClass=
 cumulusci.package.uninstallClass=
 cumulusci.github.url.raw=https://raw.github.com/SalesforceFoundation/Recurring_Donations
diff --git a/src/classes/RecurringDonations.cls-meta.xml b/src/classes/RecurringDonations.cls-meta.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
-    <apiVersion>29.0</apiVersion>
+    <apiVersion>36.0</apiVersion>
     <status>Active</status>
 </ApexClass>
diff --git a/src/classes/RecurringDonationsPkgVersionCheck.cls-meta.xml b/src/classes/RecurringDonationsPkgVersionCheck.cls-meta.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
-    <apiVersion>29.0</apiVersion>
+    <apiVersion>36.0</apiVersion>
     <status>Active</status>
 </ApexClass>
diff --git a/src/classes/RecurringDonations_BATCH.cls-meta.xml b/src/classes/RecurringDonations_BATCH.cls-meta.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
-    <apiVersion>29.0</apiVersion>
+    <apiVersion>36.0</apiVersion>
     <status>Active</status>
 </ApexClass>
diff --git a/src/classes/RecurringDonations_SCHED.cls-meta.xml b/src/classes/RecurringDonations_SCHED.cls-meta.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
-    <apiVersion>29.0</apiVersion>
+    <apiVersion>36.0</apiVersion>
     <status>Active</status>
 </ApexClass>
diff --git a/src/classes/RecurringDonations_TEST.cls-meta.xml b/src/classes/RecurringDonations_TEST.cls-meta.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
-    <apiVersion>29.0</apiVersion>
+    <apiVersion>36.0</apiVersion>
     <status>Active</status>
 </ApexClass>
diff --git a/src/layouts/Recurring_Donation__c-Recurring Donation Layout.layout b/src/layouts/Recurring_Donation__c-Recurring Donation Layout.layout
@@ -115,18 +115,12 @@
         <style>CustomLinks</style>
     </layoutSections>
     <quickActionList>
-        <quickActionListItems>
-            <quickActionName>FeedItem.TextPost</quickActionName>
-        </quickActionListItems>
         <quickActionListItems>
             <quickActionName>Recurring_Donation__c.Quick_Update</quickActionName>
         </quickActionListItems>
         <quickActionListItems>
             <quickActionName>Recurring_Donation__c.New_Opportunity</quickActionName>
         </quickActionListItems>
-        <quickActionListItems>
-            <quickActionName>FeedItem.ContentPost</quickActionName>
-        </quickActionListItems>
         <quickActionListItems>
             <quickActionName>NewNote</quickActionName>
         </quickActionListItems>

diff --git a/src/objects/Custom_Field_Mapping__c.object b/src/objects/Custom_Field_Mapping__c.object
@@ -1,12 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
     <customSettingsType>List</customSettingsType>
-    <customSettingsVisibility>Public</customSettingsVisibility>
     <description>Maps Recurring Donation fields to Opportunity fields.</description>
     <enableFeeds>false</enableFeeds>
     <fields>
         <fullName>Opportunity_Field__c</fullName>
-        <deprecated>false</deprecated>
         <description>The Opportunity field to receive the value from the Recurring Donation field. Note that these fields must have the same data type.</description>
         <externalId>false</externalId>
         <inlineHelpText>The Opportunity field to receive the value from the Recurring Donation field.  Note that these fields must have the same data type.</inlineHelpText>
@@ -19,7 +17,6 @@
     </fields>
     <fields>
         <fullName>Recurring_Donation_Field__c</fullName>
-        <deprecated>false</deprecated>
         <description>The Recurring Donation field to copy to the Opportunity field. Note that these fields must have the same data type.</description>
         <externalId>false</externalId>
         <inlineHelpText>The Recurring Donation field to copy to the Opportunity field.  Note that these fields must have the same data type.</inlineHelpText>
@@ -31,4 +28,5 @@
         <unique>false</unique>
     </fields>
     <label>Custom Field Mapping</label>
+    <visibility>Public</visibility>
 </CustomObject>
diff --git a/src/objects/Custom_Installment_Settings__c.object b/src/objects/Custom_Installment_Settings__c.object
@@ -1,12 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
     <customSettingsType>List</customSettingsType>
-    <customSettingsVisibility>Public</customSettingsVisibility>
     <description>Defines custom installment periods for open-ended donations.</description>
     <enableFeeds>false</enableFeeds>
     <fields>
         <fullName>Increment__c</fullName>
-        <deprecated>false</deprecated>
         <description>The type of time period the Custom Installment Period covers.  Weeks, Months, Days</description>
         <externalId>false</externalId>
         <inlineHelpText>The type of time period the Custom Installment Period covers.</inlineHelpText>
@@ -19,7 +17,6 @@
     </fields>
     <fields>
         <fullName>Value__c</fullName>
-        <deprecated>false</deprecated>
         <description>The amount of time the Custom Installment Period covers.</description>
         <externalId>false</externalId>
         <inlineHelpText>The amount of time the Custom Installment Period covers.</inlineHelpText>
@@ -32,4 +29,5 @@
         <unique>false</unique>
     </fields>
     <label>Custom Installment Settings</label>
+    <visibility>Public</visibility>
 </CustomObject>
diff --git a/src/objects/Opportunity.object b/src/objects/Opportunity.object
@@ -3,7 +3,6 @@
     <fields>
         <fullName>Recurring_Donation__c</fullName>
         <deleteConstraint>SetNull</deleteConstraint>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <label>Recurring Donation</label>
         <referenceTo>Recurring_Donation__c</referenceTo>

diff --git a/src/objects/Recurring_Donation__c.object b/src/objects/Recurring_Donation__c.object
@@ -44,6 +44,7 @@
         <actionName>View</actionName>
         <type>Default</type>
     </actionOverrides>
+    <allowInChatterGroups>false</allowInChatterGroups>
     <compactLayoutAssignment>NPSP_Recurring_Donation_Compact_Layout</compactLayoutAssignment>
     <compactLayouts>
         <fullName>NPSP_Recurring_Donation_Compact_Layout</fullName>
@@ -53,15 +54,17 @@
         <label>NPSP Recurring Donation Compact Layout</label>
     </compactLayouts>
     <deploymentStatus>Deployed</deploymentStatus>
-    <deprecated>false</deprecated>
     <description>Recurring Donations with no end date.</description>
     <enableActivities>false</enableActivities>
+    <enableBulkApi>true</enableBulkApi>
     <enableFeeds>false</enableFeeds>
     <enableHistory>true</enableHistory>
     <enableReports>true</enableReports>
+    <enableSearch>true</enableSearch>
+    <enableSharing>true</enableSharing>
+    <enableStreamingApi>true</enableStreamingApi>
     <fields>
         <fullName>Amount__c</fullName>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <label>Amount</label>
         <precision>18</precision>
@@ -74,7 +77,6 @@
     <fields>
         <fullName>Contact__c</fullName>
         <deleteConstraint>SetNull</deleteConstraint>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <label>Contact</label>
         <referenceTo>Contact</referenceTo>
@@ -87,7 +89,6 @@
     <fields>
         <fullName>Date_Established__c</fullName>
         <defaultValue>Today()</defaultValue>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <label>Date Established</label>
         <required>false</required>
@@ -97,7 +98,6 @@
     </fields>
     <fields>
         <fullName>Donor_Name__c</fullName>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <formula>if(
   LEN(Contact__c)&gt;0,
@@ -114,7 +114,6 @@
     </fields>
     <fields>
         <fullName>Installment_Amount__c</fullName>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <formula>IF( 
 
@@ -139,7 +138,6 @@ OR(
     </fields>
     <fields>
         <fullName>Installment_Period__c</fullName>
-        <deprecated>false</deprecated>
         <description>How often you’ll receive the donations. NOTE: Changing the installment period for an existing Fixed-Length Recurring Donation may result in the loss and re-creation of open opportunities. Any data associated with those opportunities may be lost.</description>
         <externalId>false</externalId>
         <inlineHelpText>How often you’ll receive the donations. NOTE: Changing the installment period for an existing Fixed-Length Recurring Donation may result in the loss and re-creation of open opportunities. Any data associated with those opportunities may be lost.</inlineHelpText>
@@ -174,7 +172,6 @@ OR(
     <fields>
         <fullName>Installments__c</fullName>
         <defaultValue>1</defaultValue>
-        <deprecated>false</deprecated>
         <description>Number of installments (donations) you expect to receive. For Fixed-Length Recurring Donations only.</description>
         <externalId>false</externalId>
         <inlineHelpText>Number of installments (donations) you expect to receive. For Fixed-Length Recurring Donations only.</inlineHelpText>
@@ -189,7 +186,6 @@ OR(
     </fields>
     <fields>
         <fullName>Last_Payment_Date__c</fullName>
-        <deprecated>false</deprecated>
         <description>Date of the last payment for this Recurring Donation</description>
         <externalId>false</externalId>
         <inlineHelpText>Do Not Enter. The NPSP calculates this value automatically based on the last time a child donation was marked Posted.</inlineHelpText>
@@ -201,7 +197,6 @@ OR(
     </fields>
     <fields>
         <fullName>Next_Payment_Date__c</fullName>
-        <deprecated>false</deprecated>
         <description>Holds the date of the next recurring payment.  Manually editing this field will recalculate all future opportunity&apos;s close dates based on the scheduled defined.</description>
         <externalId>false</externalId>
         <inlineHelpText>The date on which you want the next donation to occur. This date also determines the date of all future donations.</inlineHelpText>
@@ -213,7 +208,6 @@ OR(
     </fields>
     <fields>
         <fullName>Open_Ended_Status__c</fullName>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <inlineHelpText>Choose Open for an Open-Ended Recurring Donation.  Choose None for a Fixed Length Recurring Donation.  Choose Closed to close a Recurring Donation.</inlineHelpText>
         <label>Open Ended Status</label>
@@ -239,7 +233,6 @@ OR(
     <fields>
         <fullName>Organization__c</fullName>
         <deleteConstraint>SetNull</deleteConstraint>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <label>Organization</label>
         <referenceTo>Account</referenceTo>
@@ -251,7 +244,6 @@ OR(
     </fields>
     <fields>
         <fullName>Paid_Amount__c</fullName>
-        <deprecated>false</deprecated>
         <description>Total Amount paid on this Recurring Donation</description>
         <externalId>false</externalId>
         <inlineHelpText>Do Not Enter. The NPSP calculates this value automatically as donations are made and marked Posted.</inlineHelpText>
@@ -266,7 +258,6 @@ OR(
     <fields>
         <fullName>Recurring_Donation_Campaign__c</fullName>
         <deleteConstraint>SetNull</deleteConstraint>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <label>Campaign</label>
         <referenceTo>Campaign</referenceTo>
@@ -278,7 +269,6 @@ OR(
     </fields>
     <fields>
         <fullName>Schedule_Type__c</fullName>
-        <deprecated>false</deprecated>
         <description>Tells Salesforce how to compute the amount for each child opportunity, based on what you&apos;ve entered in the Amount field. For Fixed-Length Recurring Donations only.</description>
         <externalId>false</externalId>
         <inlineHelpText>Tells Salesforce how to compute the amount for each child opportunity, based on what you&apos;ve entered in the Amount field. For Fixed-Length Recurring Donations only.</inlineHelpText>
@@ -300,7 +290,6 @@ OR(
     </fields>
     <fields>
         <fullName>Total_Paid_Installments__c</fullName>
-        <deprecated>false</deprecated>
         <description>Total number of installments paid on this Recurring Donation.</description>
         <externalId>false</externalId>
         <inlineHelpText>Do Not Enter. The NPSP calculates this value automatically as donations are made and marked Posted.</inlineHelpText>
@@ -315,7 +304,6 @@ OR(
     </fields>
     <fields>
         <fullName>Total__c</fullName>
-        <deprecated>false</deprecated>
         <externalId>false</externalId>
         <formula>IF(TEXT( Open_Ended_Status__c) =  $Label.RecurringDonationOpenStatus, 0,
 CASE(

diff --git a/src/objects/Recurring_Donations_Error_Queue__c.object b/src/objects/Recurring_Donations_Error_Queue__c.object
@@ -1,12 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
     <customSettingsType>List</customSettingsType>
-    <customSettingsVisibility>Public</customSettingsVisibility>
     <description>DEPRECATED.  Recurring Donations are now stored in the System Error Log.</description>
     <enableFeeds>false</enableFeeds>
     <fields>
         <fullName>Error_Message__c</fullName>
-        <deprecated>false</deprecated>
         <description>Error message for the operation on the associated Recurring Donation record</description>
         <externalId>false</externalId>
         <inlineHelpText>Error message for the operation on the associated Recurring Donation record</inlineHelpText>
@@ -19,7 +17,6 @@
     </fields>
     <fields>
         <fullName>Recurring_Donation_ID__c</fullName>
-        <deprecated>false</deprecated>
         <description>ID of the affected Recurring Donation record</description>
         <externalId>false</externalId>
         <inlineHelpText>ID of the affected Recurring Donation record</inlineHelpText>
@@ -31,4 +28,5 @@
         <unique>false</unique>
     </fields>
     <label>DEPRECATED-RD Error Queue</label>
+    <visibility>Public</visibility>
 </CustomObject>