Enforce that CI matrix contains required_ruby_version & .ruby-version
#3248
+121
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures if the version is bumped in development, it is also added to the matrix.
We should always test against the minimum Ruby version we support, and it shouldn't be removed without also bumping the `required_ruby_version` in the gemspec.
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
- Bundler 2.6 requires Ruby 3.1 - Tapioca > 0.14 requires Ruby 3.1 I've changed `BUNDLED WITH` to the latest version in the 2.5 series, which supports Ruby 3.0, and I've removed the version requirement on `tapioca` (and run `bundle update`). Let's see if this passes CI...
sambostock
force-pushed
the
enforce-ci-matrix-ruby-versions
branch
from
b579687 to
808e375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our CI matrix should always include, at least:
.ruby-version, andrequired_ruby_versioninruby-lsp.gemspec#2017 dropped Ruby 3.0 from the CI matrix without changing the requirement in the gemspec.
Implementation
This adds a pair of tests to enforce all CI matrix
ruby: [...]entries contain the Ruby versions listed.ruby-version, andrequired_ruby_versioninruby-lsp.gemspec.Ruby 3.0 is also added back to the CI matrix, which gets the test passing again.
There should be no consumer facing changes. If we do want to remove Ruby 3.0 again, then that belongs in a separate PR which also changes the
ruby-lsp.gemspec(and is probably a major version bump).Automated Tests
Yes, see above.