Enforce that CI matrix contains required_ruby_version & .ruby-version

.github/workflows/ci.yml

@@ -44,7 +44,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        ruby: ["3.1", "3.2", "3.3", "3.4"]
+        ruby: ["3.0", "3.1", "3.2", "3.3", "3.4"]
     runs-on: ${{ matrix.os }}
     timeout-minutes: 30
     name: Ruby ${{ matrix.ruby }} on ${{ matrix.os }}

Gemfile

@@ -25,6 +25,6 @@ group :development do
   platforms :ruby do # C Ruby (MRI), Rubinius or TruffleRuby, but NOT Windows
     # sorbet-static is not available on Windows. We also skip Tapioca since it depends on sorbet-static-and-runtime
     gem "sorbet-static-and-runtime"
-    gem "tapioca", "~> 0.16", require: false
+    gem "tapioca", require: false # , "~> 0.16", require: false
   end
 end

Gemfile.lock

@@ -12,52 +12,57 @@ GEM
   specs:
     ansi (1.5.0)
     ast (2.4.2)
-    benchmark (0.4.0)
     builder (3.3.0)
-    debug (1.9.2)
+    date (3.4.1)
+    debug (1.10.0)
       irb (~> 1.10)
       reline (>= 0.3.8)
     docile (1.4.1)
     erubi (1.13.1)
-    io-console (0.7.2)
-    irb (1.14.1)
+    io-console (0.8.0)
+    irb (1.15.1)
+      pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
     json (2.10.1)
     language_server-protocol (3.17.0.4)
     lint_roller (1.1.0)
-    logger (1.6.1)
-    minitest (5.25.1)
+    logger (1.6.6)
+    minitest (5.25.4)
     minitest-reporters (1.7.1)
       ansi
       builder
       minitest (>= 5.0)
       ruby-progressbar
-    mocha (2.4.5)
+    mocha (2.7.1)
       ruby2_keywords (>= 0.0.5)
     netrc (0.11.0)
     parallel (1.26.3)
     parser (3.3.7.1)
       ast (~> 2.4.1)
       racc
+    pp (0.6.2)
+      prettyprint
     prettier_print (1.2.1)
+    prettyprint (0.2.0)
     prism (1.3.0)
-    psych (5.1.2)
+    psych (5.2.3)
+      date
       stringio
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.2.1)
-    rbi (0.2.3)
-      prism (~> 1.0)
+    rbi (0.1.2)
+      prism (>= 0.15.1)
       sorbet-runtime (>= 0.5.9204)
     rbs (3.6.1)
       logger
-    rdoc (6.7.0)
+    rdoc (6.12.0)
       psych (>= 4.0.0)
     regexp_parser (2.10.0)
-    reline (0.5.10)
+    reline (0.6.0)
       io-console (~> 0.5)
-    rubocop (1.72.0)
+    rubocop (1.73.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -68,7 +73,7 @@ GEM
       rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.0)
+    rubocop-ast (1.38.1)
       parser (>= 3.3.1.0)
     rubocop-md (1.2.4)
       rubocop (>= 1.45)
@@ -79,7 +84,7 @@ GEM
       rubocop (~> 1.0)
     rubocop-shopify (2.15.1)
       rubocop (~> 1.51)
-    rubocop-sorbet (0.8.7)
+    rubocop-sorbet (0.8.9)
       rubocop (>= 1)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
@@ -89,41 +94,39 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    sorbet (0.5.11842)
-      sorbet-static (= 0.5.11842)
-    sorbet-runtime (0.5.11842)
-    sorbet-static (0.5.11842-universal-darwin)
-    sorbet-static (0.5.11842-x86_64-linux)
-    sorbet-static-and-runtime (0.5.11842)
-      sorbet (= 0.5.11842)
-      sorbet-runtime (= 0.5.11842)
-    spoom (1.5.4)
+    sorbet (0.5.11862)
+      sorbet-static (= 0.5.11862)
+    sorbet-runtime (0.5.11862)
+    sorbet-static (0.5.11862-universal-darwin)
+    sorbet-static (0.5.11862-x86_64-linux)
+    sorbet-static-and-runtime (0.5.11862)
+      sorbet (= 0.5.11862)
+      sorbet-runtime (= 0.5.11862)
+    spoom (1.2.4)
       erubi (>= 1.10.0)
-      prism (>= 0.28.0)
-      rbi (>= 0.2.3)
       sorbet-static-and-runtime (>= 0.5.10187)
+      syntax_tree (>= 6.1.1)
       thor (>= 0.19.2)
-    stringio (3.1.1)
+    stringio (3.1.5)
     syntax_tree (6.2.0)
       prettier_print (>= 1.2.0)
-    tapioca (0.16.7)
-      benchmark
+    tapioca (0.11.10)
       bundler (>= 2.2.25)
       netrc (>= 0.11.0)
       parallel (>= 1.21.0)
-      rbi (~> 0.2)
-      sorbet-static-and-runtime (>= 0.5.11087)
-      spoom (>= 1.2.0)
+      rbi (~> 0.1.0, >= 0.1.0)
+      sorbet-static-and-runtime (>= 0.5.10187)
+      spoom (~> 1.2.0, >= 1.2.0)
       thor (>= 1.2.0)
       yard-sorbet
     thor (1.3.2)
     unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
     yard (0.9.37)
-    yard-sorbet (0.9.0)
-      sorbet-runtime
-      yard
+    yard-sorbet (0.8.1)
+      sorbet-runtime (>= 0.5)
+      yard (>= 0.9)
 
 PLATFORMS
   arm64-darwin
@@ -150,7 +153,7 @@ DEPENDENCIES
   simplecov
   sorbet-static-and-runtime
   syntax_tree (>= 6.1.1, < 7)
-  tapioca (~> 0.16)
+  tapioca
 
 BUNDLED WITH
-   2.6.2
+   2.5.23

test/ci_configuration_test.rb

@@ -0,0 +1,79 @@
+# typed: true
+# frozen_string_literal: true
+
+require "test_helper"
+require "yaml"
+
+class CiConfigurationTest < Minitest::Test
+  def test_matrix_includes_minimum_ruby_version
+    minimum_ruby_version = minimum_ruby_version_from_gemspec
+
+    each_ci_matrix_ruby_entry do |matrix_ruby_versions, path|
+      assert_includes(
+        matrix_ruby_versions,
+        minimum_ruby_version,
+        "CI matrix #{path.join(".")} does not include minimum required ruby version #{minimum_ruby_version}",
+      )
+    end
+  end
+
+  def test_matrix_includes_development_ruby_version
+    development_ruby_version = development_ruby_version_from_dot_ruby_version_file
+
+    each_ci_matrix_ruby_entry do |matrix_ruby_versions, path|
+      assert_includes(
+        matrix_ruby_versions,
+        development_ruby_version,
+        "CI matrix #{path.join(".")} does not include development ruby version #{development_ruby_version}",
+      )
+    end
+  end
+
+  private
+
+  def minimum_ruby_version_from_gemspec
+    minimum_ruby_version = File.read("ruby-lsp.gemspec")[/(?<=required_ruby_version = ">= ).*(?="$)/]
+
+    return minimum_ruby_version unless minimum_ruby_version.nil?
+
+    flunk("Failed to extract required_ruby_version from gemspec")
+  end
+
+  def development_ruby_version_from_dot_ruby_version_file
+    contents = File.read(".ruby-version").chomp
+    flunk("Failed to read .ruby-version file") if contents.empty?
+
+    major_and_minor_only = contents[/\d+\.\d+/]
+    flunk("Failed to extract major and minor version from .ruby-version file") if major_and_minor_only.nil?
+
+    major_and_minor_only
+  end
+
+  def each_ci_matrix_ruby_entry(&block)
+    each_ci_matrix_entry do |matrix, path|
+      matrix_ruby_versions = matrix["ruby"]
+      next if matrix_ruby_versions.nil?
+
+      yield(matrix_ruby_versions, path)
+    end
+  end
+
+  def each_ci_matrix_entry(hash = read_ci_workflow, path: [], &block)
+    case hash
+    when Hash
+      hash.each do |key, value|
+        if key == "matrix"
+          yield(value, path)
+        else
+          each_ci_matrix_entry(value, path: path + [key], &block)
+        end
+      end
+    when Array
+      hash.each_with_index { |value, index| each_ci_matrix_entry(value, path: path + [index], &block) }
+    end
+  end
+
+  def read_ci_workflow
+    YAML.load_file(".github/workflows/ci.yml")
+  end
+end