Modify locations of kw arguments and params to match legacy parser #390
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Dec 20, 2024
egiurleo
force-pushed
the
emily/namer-tests
branch
2 times, most recently
from
8e19f2b to
be4d1f7
Compare
egiurleo
force-pushed
the
emily/fix-389
branch
from
62799f5 to
a3203c8
Compare
egiurleo
force-pushed
the
emily/fix-389
branch
from
a3203c8 to
879509a
Compare
egiurleo
force-pushed
the
emily/fix-389
branch
from
879509a to
4457588
Compare
st0012
approved these changes
Dec 23, 2024
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #389
Motivation
We needed to slightly modify the locations of keyword arguments and params in order to match the behavior of Sorbet's legacy parser. This allows us to run four of the previously-failing namer tests.
Test plan
See included automated tests.