Fix prawn suit drilling doesn't save raw materials globally #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coding-Hen
requested changes
Mar 9, 2025
Comment on lines
22
to
23
| var ITEM_SERVICE = NitroxServiceLocator.LocateService<Items>(); | ||
| ITEM_SERVICE.PickedUp(instanceGameObject, instanceTechType); |
There was a problem hiding this comment.
I think you should be able to call this directly like other patches do without having to assign it first.
Suggested change
| var ITEM_SERVICE = NitroxServiceLocator.LocateService<Items>(); | |
| ITEM_SERVICE.PickedUp(instanceGameObject, instanceTechType); | |
| Resolve<Items>().PickedUp(instanceGameObject, instanceTechType); |
| { | ||
| public static readonly MethodInfo TARGET_METHOD = Reflect.Method((ResourceTracker d) => d.OnPickedUp(default)); | ||
|
|
||
| public static bool Prefix(ResourceTracker __instance, Pickupable p) |
There was a problem hiding this comment.
I don't think you need pickupable here as you don't make use of it
Suggested change
| public static bool Prefix(ResourceTracker __instance, Pickupable p) | |
| public static bool Prefix(ResourceTracker __instance) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue link: #2278