-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully sync exosuits and drilling #2304
base: master
Are you sure you want to change the base?
Conversation
GJ on the PR @SpaceMonkeyy86 I found 4 bugs that u might have missed
Everything else works great :D. Keep up the good work |
@leonidasjan These should be fixed now. For the sound effects, that is not really relevant for this PR since the sound is synced, but it was probably designed to play regardless of world position, since you are normally right on top of it. We will get around to reworking those sounds sometime, though. |
Good work on the bug fixes @SpaceMonkeyy86 😄 The bugs i listed are gone (except for the sound issues but i understand that its for the future). The only thing ive noticed is that there are still some bugs while grabbing another player with the hook. If you want u can fix those issues but IMO grabbing other players should be disabled cause its a little weird. from the bug testing perspective the pr is almost ready to merge |
@leonidasjan Thanks, it should be impossible for other players to be hit with the grappling hook now. |
Fixes #2278