Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully sync exosuits and drilling #2304

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

SpaceMonkeyy86
Copy link
Contributor

@SpaceMonkeyy86 SpaceMonkeyy86 commented Mar 9, 2025

  • Sync claw arms
  • Sync drill arms
  • Sync drill arm position when drilling (automatically moves down to deposit)
  • Sync grappling arms
  • Sync grappling hook from grappling arms
  • Sync propulsion arms
  • Sync torpedo arms
  • Sync exosuit power cells
  • Sync drillable deposits visually disappearing in parts when drilled
  • Sync resources spawning from drillable deposits
  • Sync "pinata" resources automatically going into vehicle storage
  • Sync respawning ion cube deposit in primary containment facility antechamber
  • Persist destroyed status of deposits when saving

Fixes #2278

@SpaceMonkeyy86 SpaceMonkeyy86 marked this pull request as draft March 9, 2025 21:41
@Measurity Measurity added Area: vehicles Related to vehicles (seamoth, cyclops, prawn) Area: spawning Related to spawning and/or terrain Area: items Related to items and inventories labels Mar 10, 2025
@Measurity Measurity added this to the 1.8 milestone Mar 10, 2025
@SpaceMonkeyy86 SpaceMonkeyy86 marked this pull request as ready for review March 13, 2025 21:06
@leonidasjan
Copy link

GJ on the PR @SpaceMonkeyy86

I found 4 bugs that u might have missed

  1. The second power cell in the exosuit isn’t synced at all.

  2. If you swap an arm from one slot to another, it first vanishes for everyone, then reappears—but only for the second player.

  3. If you repeatedly equip and unequip an arm, it can sometimes duplicate (this might be just lag but i can do it consistently).

  4. The other player can still hear some sounds from the exosuit when the other player is far away (like 0,5km away). When u let go of the spacebar, they can hear for split second the jetpack/engine "revving off". Occasionally they can also hear a loud stomp from the exosuit.

Everything else works great :D. Keep up the good work

@SpaceMonkeyy86
Copy link
Contributor Author

@leonidasjan These should be fixed now. For the sound effects, that is not really relevant for this PR since the sound is synced, but it was probably designed to play regardless of world position, since you are normally right on top of it. We will get around to reworking those sounds sometime, though.

@leonidasjan
Copy link

leonidasjan commented Mar 23, 2025

Good work on the bug fixes @SpaceMonkeyy86 😄

The bugs i listed are gone (except for the sound issues but i understand that its for the future).

The only thing ive noticed is that there are still some bugs while grabbing another player with the hook. If you want u can fix those issues but IMO grabbing other players should be disabled cause its a little weird.

from the bug testing perspective the pr is almost ready to merge

@SpaceMonkeyy86
Copy link
Contributor Author

@leonidasjan Thanks, it should be impossible for other players to be hit with the grappling hook now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: items Related to items and inventories Area: spawning Related to spawning and/or terrain Area: vehicles Related to vehicles (seamoth, cyclops, prawn)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prawn suit drilling doesn't save raw materials globally
3 participants