-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct full_domain=True
For from_pandas
#1239
base: dev
Are you sure you want to change the base?
Conversation
I am running into one issue though. When I try to create the full domain for
I get this error:
But I don't think I should be? |
I'll have to look closer later, it fails even with |
This pull request has been linked to: |
* Previously, the `tile_max` was only correctly calculated for `np.int64`. This correctly set the `dim_max` to `dtype_max - tile` but only for `np.int64` * All other integer dtypes had `dim_max` set to `dtype_max` which resulted in a domain range that was too large * We also need to account for when the tile extent is larger than the range of the full domain. For an instance, when we have a dim dtype of `np.int8`, the default tile extent of 10000 will be much larger than the range of the full domain
38634c1
to
def094a
Compare
* I was mistakenly under the impression that `tiledb.Dim(domain=(-128, 126), tile=254, dtype=np.int8)` was a valid tile extent for int8. But since the max value of int8 is 128, not 256, we can't have an extent larger than that.
I was mistakenly under the impression that |
tile_max
was only correctly calculated fornp.int64
. This correctly set thedim_max
todtype_max - tile
but only for
np.int64
dim_max
set todtype_max
whichresulted in a domain range that was too large
the range of the full domain. For an instance, when we have a dim
dtype of
np.int8
, the default tile extent of 10000 will be muchlarger than the range of the full domain