Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct full_domain=True For from_pandas #1239

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Correct full_domain=True For from_pandas #1239

wants to merge 3 commits into from

Commits on Aug 24, 2022

  1. Correct full_domain=True For from_pandas 

    * Previously, the `tile_max` was only correctly calculated for
  `np.int64`. This correctly set the `dim_max` to `dtype_max - tile`
  but only for `np.int64`
* All other integer dtypes had `dim_max` set to `dtype_max` which
  resulted in a domain range that was too large
* We also need to account for when the tile extent is larger than
  the range of the full domain. For an instance, when we have a dim
  dtype of `np.int8`, the default tile extent of 10000 will be much
  larger than the range of the full domain
    @nguyenv
    nguyenv committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    623eb32 View commit details
    Browse the repository at this point in the history

  2. Add Documentation To Clarify The full_domain Logic

    @nguyenv
    nguyenv committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    def094a View commit details
    Browse the repository at this point in the history

  3. Correct Logic For Accounting For Signed Integers 

    * I was mistakenly under the impression that
  `tiledb.Dim(domain=(-128, 126), tile=254, dtype=np.int8)` was
  a valid tile extent for int8. But since the max value of int8 is
  128, not 256, we can't have an extent larger than that.
    @nguyenv
    nguyenv committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    759b749 View commit details
    Browse the repository at this point in the history