-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voron volumetric speed #20023
Open
NerdyGriffin
wants to merge
86
commits into
Ultimaker:main
Choose a base branch
from
NerdyGriffin:voron-volumetric-speed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Voron volumetric speed #20023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: Community Contribution 👑
Community Contribution PR's
label
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Test Results23 370 tests 23 368 ✅ 46s ⏱️ Results for commit 62a3b6b. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the Voron base definition files and material profiles to make better use of the latest features and defaults inherited from
fdmprinter.def.json
. The goal is to simplify the printer definition, reduce the number of redundant lines of code, and replace hard-coded values with parametric definitions so that the base printer definition can more effectively adapt to custom Voron printer configurations. I have also designed the behavior of these printer definitions to be more consistent with the community-made Voron definitions found in other open-source slicers, to keep these definitions up-to-date with the changes and improvements that have been made to both the Voron printer hardware and Voron support/compatibility seen on other slicers.I have chosen the parametric print speeds so that they result in the exact same print speeds as the previous hard-coded values. This ensures that print speeds continue to be calculated appropriately for other combinations of nozzle sizes and layer heights that are not yet standardized in this printer definition, while keeping this new printer definition fully backwards-compatible with existing Voron users' custom print/material profiles.
Type of change
How Has This Been Tested?
print_speed
values for all the supported material types.cool_min_speed
,travel_speed
, etc.), I manually checked the values displayed in the slicer when using different combinations of printers, nozzle sizes, layer heights, and material types to ensure that they were calculated to the results I intended.Test Configuration:
Checklist: