- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voron volumetric speed #20023
Open
NerdyGriffin
wants to merge
88
commits into
Ultimaker:main
Choose a base branch
from
NerdyGriffin:voron-volumetric-speed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+167
−606
Open
Voron volumetric speed #20023
Changes from all commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
d3d63bf
Fix cool_min_speed
WCEngineer dbc031f
Experimental: simplified speed definitions to take advantage of defaults
WCEngineer 78fa756
Enforce lower limit on cool_min_speed
WCEngineer 1f51ede
Update max_feedrate and max_accel based on latest default voron-2 pri…
WCEngineer b64c0b6
Remove old jerk settings because jerk is disabled
WCEngineer 469cb00
Update speed_travel to automatically adjust for changes to max_feedrate
WCEngineer d0d7f61
Remove old acceleration control values
WCEngineer 387566b
Update layer_height_0 to dynamically adjust to nozzle size
WCEngineer e3b00b8
Update machine_acceleration to match machine_max_acceleration
WCEngineer fe4ae91
Fix cool_min_speed lower limit
WCEngineer 181d378
Revert "Experimental: simplified speed definitions to take advantage …
WCEngineer a21c88f
Set z-hop speed to max feedrate
WCEngineer c11d42e
Simplified speeds in voron base definition to use values inherited fr…
WCEngineer b1595cd
Update global quality profiles to calculate speed using volumetric flow
WCEngineer 0a3a156
Simplify travel speed calculation
WCEngineer cd4f7c4
Update v6 quality profiles to use speeds inherited from the global pr…
WCEngineer eaf5491
Update volcano profiles to using volumetric flow calculation
WCEngineer f1c6ed8
Applied printer-linter format
WCEngineer f342548
Merge branch 'voron-nozzles' into voron-volumetric-speed
WCEngineer 7a74084
Merge branch 'voron-volumetric-speed' of https://github.com/NerdyGrif…
WCEngineer 17cc53d
Update ASA, PVA, and TPU profiles
WCEngineer db96d50
Prevent rounding travel speed to zero
WCEngineer acb63af
Fix rounding (missing "=" after "speed_print =")
WCEngineer 3d1c291
Revert "Fix rounding (missing "=" after "speed_print =")"
WCEngineer a940a87
Fix rounding, rerun printer-linter
WCEngineer 0d439ad
Update travel speed lower limit to follow speed_print
WCEngineer 23262cc
Move default speed_print from global quality profiles to printer defi…
WCEngineer ed87000
Fix incorrect speed variable in cool_min_speed calculation
WCEngineer d0c9ade
Update wall thickness to dynamically adjust to nozzle size
WCEngineer cd0cf77
Merge branch 'main' into voron-volumetric-speed
NerdyGriffin b150b27
Merge branch 'main' into voron-volumetric-speed
NerdyGriffin 5739b9c
Update profile versions in Voron files
NerdyGriffin 69ac649
Merge branch 'voron-profile-version' into voron-volumetric-speed
NerdyGriffin f34ee9a
Overriding acceleration_enabled with the same value (default_value: F…
NerdyGriffin e132ecf
Overriding cool_fan_speed_min with the same value (value: cool_fan_sp…
NerdyGriffin 8f195ad
Update resources/definitions/voron2_base.def.json
NerdyGriffin 1242026
Merge branch 'voron-volumetric-speed' of https://github.com/NerdyGrif…
NerdyGriffin 5b832ae
Applied printer-linter format
NerdyGriffin 4baedce
Overriding jerk_enabled with the same value (default_value: False) as…
NerdyGriffin cb3695e
Remove experimental settings from default profile
NerdyGriffin 24185be
Revert "Remove experimental settings from default profile"
NerdyGriffin 0a188a2
retrigger checks
NerdyGriffin 7a81cca
retrigger checks
NerdyGriffin ca0cb3d
Revert contents of TPU profiles to correct version
NerdyGriffin 955bc5a
Merge branch 'voron-profile-version' into voron-volumetric-speed
NerdyGriffin 7b6e941
Applied printer-linter format
NerdyGriffin e558ad8
Fix relatationship between default line width and its child values
NerdyGriffin 586b49a
Remove redundant line_width
NerdyGriffin a872413
Applied printer-linter format
NerdyGriffin 12274e1
Revert infill and first layer speed to values inherited from fdmprinter
NerdyGriffin 0ffc1f2
Increase default volumetric flow based of community feedback
NerdyGriffin e0c1b8c
Increase default speeds and acceleration
NerdyGriffin feb95f3
Decrease speed_layer_0 back to a more reasonable value
NerdyGriffin dce075b
Round volumetric flow to a multiple of 0.2 for better results
NerdyGriffin a5a9955
Update TPU profiles to account for the new default speed_print
NerdyGriffin 27f0149
Decrease z hop speed
NerdyGriffin 94ab1fe
Remove more redundant overrides
NerdyGriffin c2a66bf
Parametric cool_min_layer_time_fan_speed_max
NerdyGriffin 8a6d84c
Decrease default print speed
NerdyGriffin 8e73e91
Update retraction (Voron)
NerdyGriffin 97c8635
Restore travel_avoid_other_parts to default
NerdyGriffin a72ade3
Zig-zaggify Supports by default
NerdyGriffin f3bd534
Fix error: parametric in "default_value" instead of "value"
NerdyGriffin 5b2e35d
Restore default print speed
NerdyGriffin 5c3cfaa
Revert "Revert infill and first layer speed to values inherited from …
NerdyGriffin 5addbc5
Revert "Update TPU profiles to account for the new default speed_print"
NerdyGriffin af7fb34
Force update PR
NerdyGriffin 209cec7
Default to smart hiding seam
NerdyGriffin f8c4008
Test acceleration control
NerdyGriffin 36fc19c
Increase default machine_acceleration
NerdyGriffin 1166634
Test jerk control
NerdyGriffin 74f3c7b
Revert "Test jerk control"
NerdyGriffin 072c524
Revert "Test acceleration control"
NerdyGriffin 132444b
Merge branch 'main' into voron-volumetric-speed
NerdyGriffin 367cf9e
Revert default machine_max_acceleration for new users
NerdyGriffin bfe581e
Test parametric adhesion type
NerdyGriffin 16a28fe
Revert retraction_prime_speed to inherited parametric value
NerdyGriffin 7595697
Increase infill line width
NerdyGriffin 0ab10dd
Set default infill for voron
NerdyGriffin f6478cc
Reapply "Test acceleration control"
NerdyGriffin a70807a
Merge parametric accelerations for voron
NerdyGriffin 5cffb96
Revert "Revert default machine_max_acceleration for new users"
NerdyGriffin 8826be3
Remove "alternate_extra_perimeter"
NerdyGriffin b35752a
Enable elephant's foot compensation
NerdyGriffin 3b336c8
Merge branch 'main' into voron-volumetric-speed
NerdyGriffin 62a3b6b
Fix capitalization for PRINT_START and PRINT_END macros
NerdyGriffin aa3dc59
Fix string syntax for adhesion_type
NerdyGriffin 5ce0dc9
Merge branch 'main' into voron-volumetric-speed
NerdyGriffin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 180 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 240 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 180 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 240 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 180 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 240 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 180 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 240 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 180 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 240 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 180 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 240 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 180 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.25mm | ||
|
||
[values] | ||
speed_print = 240 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.30mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.30mm | ||
|
||
[values] | ||
speed_print = 160 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.30mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.30mm | ||
|
||
[values] | ||
speed_print = 200 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,5 +11,4 @@ type = quality | |
variant = V6 0.30mm | ||
|
||
[values] | ||
speed_print = 300 | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm doing something wrong, but it appears that there is an issue with
adhesion_type
not recognizing the values when written this way. Seen in the cura log asNameError: name 'skirt' is not defined
. Tested on Cura 5.9 and 5.10-alpha in Windows.I was able to fix it and adhesion works properly by deleting default_value and adding quotes around each string value:
"adhesion_type": { "value": "'brim' if draft_shield_enabled else 'skirt'" },
Example of other printers doing it this way:
Cura/resources/definitions/lotmaxx_sc10.def.json
Line 18 in ac0fd92
Cura/resources/definitions/lotmaxx_sc20.def.json
Line 18 in ac0fd92
If this is an error on my parts somewhere, I really apologize for wasting your time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct about the single quotes, I have fixed that error before, so I am surprised it is missing from this branch. Thank you for pointing it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, after some more testing, I was able to verify that
default_value
does work correctly. It seems the only issue was the quotes. Logs are clear now. Sorry for that part.You're welcome, glad it helped! Your pull request has helped me as a reference for better default settings for Cura profile for the Peopoly Magneto X printer. Thank you for your work!