-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageUploader增加手动上传功能 #6289 #6311
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6311 +/- ##
==========================================
- Coverage 91.56% 91.55% -0.01%
==========================================
Files 306 306
Lines 6591 6598 +7
Branches 1627 1628 +1
==========================================
+ Hits 6035 6041 +6
- Misses 521 522 +1
Partials 35 35
☔ View full report in Codecov by Sentry. |
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6311.surge.sh |
get nativeElement() { | ||
return inputRef.current | ||
}, | ||
openPhoto: () => inputRef.current?.click(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得 openPhoto
就不用暴露了,本质就是 input.click()
,有 nativeElement
够了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好滴 我修改下
分支把之前得 commit 带进来了 |
see: #6316 |
刚好看到,随手加了下。不过有点不太确定的是
这里的 test 实在想不出什么好的办法去测试
openPhoto
方法,希望大佬们赐教。