Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for incoming ref to image-uploader #6316

Merged
merged 36 commits into from
Aug 17, 2023

Conversation

19Qingfeng
Copy link
Contributor

@19Qingfeng 19Qingfeng commented Aug 14, 2023

resolve #6289 ,从 #6311 移动。

1587315093 and others added 30 commits July 4, 2023 19:23
…itch (ant-design#6232)

* doc: update SwupeAction doc

* doc: update ProgressBar  ProgressCircle doc

* doc: update Popover doc

* doc: update Switch doc
* fix: fix placeholder show when value is number 0 on virtual-input

* test: add value `0`

---------

Co-authored-by: wuguangsen.wgs <[email protected]>
Co-authored-by: miracles1919 <[email protected]>
…its parent (ant-design#6239)

fix: hidden textarea element is not positioned relative to its parent
* enhance: useWheel dir change

* enhance: 代码风格调整

* refactor: 数组解构方式优化

* style: delete note code
* fix(TextArea): rows should be the smallest of default and autoSize

* refactor: adjust rows logic
* refactor: to simplify the judge

* refactor: simplify the judge

* fix: add null judge

* fix: add judage case
)

* refactor(Calendar): change locale from method to string

* test(ConfigProvider): remove spaces in Japanese translation in calendar

---------

Co-authored-by: litaoq <[email protected]>
* enhance: passive and preventDefault coexist repair

* refactor: code simplify

* test: add useLockScroll test case
fix(toast): compatible with rtl mode

Co-authored-by: Fog3211 <[email protected]>
enhance: fix passive and preventDefault in components
* chore: code simplify

* chore: code simplify
…n#6253 (ant-design#6254)

* fix: useLockScroll whether the element scroll is in the end ant-design#6253

* test: useLockScroll test case ant-design#6253

* fix: useLockScroll whether the element scroll is in the end ant-design#6253

* test: useLockScroll whether the element scroll is in the end ant-design#6253

* test: useLockScroll with strict params ant-design#6253

* test: useLockScroll with strict params ant-design#6253

* fix: del px and remove {} ant-design#6253
* fix: error-block Normal display 0

* test: add test case
@github-actions
Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6316.surge.sh

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 93.44% and no project coverage change.

Comparison is base (5ed6ffd) 91.58% compared to head (7b5718a) 91.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           feature    #6316   +/-   ##
========================================
  Coverage    91.58%   91.59%           
========================================
  Files          308      308           
  Lines         6609     6614    +5     
  Branches      1629     1629           
========================================
+ Hits          6053     6058    +5     
  Misses         521      521           
  Partials        35       35           
Files Changed Coverage Δ
src/components/image-uploader/index.ts 100.00% <ø> (ø)
src/index.ts 100.00% <ø> (ø)
src/components/image-uploader/image-uploader.tsx 94.11% <93.44%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miracles1919 miracles1919 changed the title feat: support for incoming ref to image-uploader #6289 feat: support for incoming ref to image-uploader Aug 16, 2023
@miracles1919 miracles1919 changed the base branch from master to feature August 16, 2023 14:57
@miracles1919
Copy link
Contributor

我在你基础上微调了下

  • index export ref type
  • 改了下 md 的展示为题和微微美化了下 demo

@zombieJ zombieJ merged commit 4a86cfd into ant-design:feature Aug 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants