-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tabs): support RTL mode #6314
Conversation
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6314.surge.sh |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #6314 +/- ##
===========================================
- Coverage 91.05% 91.00% -0.05%
===========================================
Files 307 307
Lines 6597 6616 +19
Branches 1644 1653 +9
===========================================
+ Hits 6007 6021 +14
- Misses 544 549 +5
Partials 46 46
☔ View full report in Codecov by Sentry. |
【1】:之前的多次提交 这个CI有点迷,我【2】和【3】这两次操作触发的action都挂掉了。。。然后【4】又好了 https://github.com/ant-design/ant-design-mobile/actions/runs/5847933615/job/15854669820#step:11:47 |
CI 好像有时候不是pr问题,得重跑一下 |
) | ||
|
||
if (isRTL) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if else 里,上面的代码在 rtl 里跑着没意义~
resolve #6081
#6313