Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tabs): support RTL mode #6314

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Conversation

Fog3211
Copy link
Contributor

@Fog3211 Fog3211 commented Aug 13, 2023

resolve #6081

#6313

@github-actions
Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6314.surge.sh

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch coverage: 68.42% and project coverage change: -0.05% ⚠️

Comparison is base (e8f6c15) 91.05% compared to head (33526e7) 91.00%.
Report is 1 commits behind head on feature.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #6314      +/-   ##
===========================================
- Coverage    91.05%   91.00%   -0.05%     
===========================================
  Files          307      307              
  Lines         6597     6616      +19     
  Branches      1644     1653       +9     
===========================================
+ Hits          6007     6021      +14     
- Misses         544      549       +5     
  Partials        46       46              
Files Changed Coverage Δ
src/components/tabs/tabs.tsx 92.96% <68.42%> (-3.46%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fog3211
Copy link
Contributor Author

Fog3211 commented Aug 13, 2023

【1】:之前的多次提交
【2】:小改动,React.ReactNode => ReactNode
【3】:小改动,删掉doc的一个标点符号,重新触发CI
【4】:回滚到【2】

这个CI有点迷,我【2】和【3】这两次操作触发的action都挂掉了。。。然后【4】又好了

https://github.com/ant-design/ant-design-mobile/actions/runs/5847933615/job/15854669820#step:11:47
https://github.com/ant-design/ant-design-mobile/actions/runs/5847785782/job/15854391415#step:4:231

@1587315093
Copy link
Contributor

【1】:之前的多次提交 【2】:小改动,React.ReactNode => ReactNode 【3】:小改动,删掉doc的一个标点符号,重新触发CI 【4】:回滚到【2】

这个CI有点迷,我【2】和【3】这两次操作触发的action都挂掉了。。。然后【4】又好了

https://github.com/ant-design/ant-design-mobile/actions/runs/5847933615/job/15854669820#step:11:47 https://github.com/ant-design/ant-design-mobile/actions/runs/5847785782/job/15854391415#step:4:231

CI 好像有时候不是pr问题,得重跑一下

src/components/tabs/demos/demo5.tsx Outdated Show resolved Hide resolved
src/components/tabs/demos/demo5.tsx Outdated Show resolved Hide resolved
src/components/tabs/tabs.tsx Outdated Show resolved Hide resolved
)

if (isRTL) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if else 里,上面的代码在 rtl 里跑着没意义~

@Fog3211 Fog3211 requested a review from zombieJ August 15, 2023 08:44
@zombieJ zombieJ merged commit 69b350a into ant-design:feature Aug 23, 2023
8 checks passed
@Fog3211 Fog3211 deleted the feat_tabs_rtl branch August 30, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants