feat(tabs): support RTL mode #6313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6313.surge.sh |
|
test挂了~ |
|
没搞过快照测试，我先学习一下再提一次pr |
1587315093
reviewed
Aug 12, 2023
src/components/tabs/index.zh.md
Outdated
| @@ -27,6 +29,7 @@ | |||
| | defaultActiveKey | 初始化选中面板的 `key`，如果没有设置 `activeKey` | `string \| null` | 第一个面板的 `key` | | |||
| | onChange | 切换面板的回调 | `(key: string) => void` | - | | |||
| | stretch | 选项卡头部是否拉伸 | `boolean` | `true` | | |||
| | rtl | 从右到左排版 | `boolean` | `false` | | |||
There was a problem hiding this comment.
rtl并不是key，而是一个value
key应该是dir (direction)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6313 +/- ##
==========================================
- Coverage 91.56% 91.46% -0.11%
==========================================
Files 306 306
Lines 6591 6605 +14
Branches 1627 1634 +7
==========================================
+ Hits 6035 6041 +6
- Misses 521 528 +7
- Partials 35 36 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.