Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to using solana_transaction_context crate #5525

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

jstarry
Copy link

@jstarry jstarry commented Mar 27, 2025

Problem

The solana_sdk::transaction_context module was deprecated in anza-xyz/solana-sdk#95 so we should stop using it before updating to newer versions of solana-sdk

Summary of Changes

Switch over to solana-transaction-context where appropriate

Fixes #

@jstarry jstarry requested review from t-nelson and seanyoung March 27, 2025 03:12
Copy link

mergify bot commented Mar 27, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @jstarry.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (e1162f7) to head (e6226aa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5525   +/-   ##
=======================================
  Coverage    83.3%    83.3%           
=======================================
  Files         829      829           
  Lines      373648   373648           
=======================================
+ Hits       311541   311568   +27     
+ Misses      62107    62080   -27     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstarry jstarry requested a review from joncinque March 27, 2025 04:15
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jstarry jstarry merged commit f0de5c3 into anza-xyz:master Mar 27, 2025
58 checks passed
@jstarry jstarry deleted the fix/use-tx-context branch March 27, 2025 14:15
@jstarry jstarry added the v2.2 Backport to v2.2 branch label Mar 27, 2025
Copy link

mergify bot commented Mar 27, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Mar 27, 2025
Migrate to using solana_transaction_context crate

(cherry picked from commit f0de5c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.2 Backport to v2.2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants