Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Auto-focus input, form #4762

Merged
merged 4 commits into from
Mar 29, 2021
Merged

UI: Auto-focus input, form #4762

merged 4 commits into from
Mar 29, 2021

Conversation

utchoang
Copy link

@utchoang utchoang commented Mar 8, 2021 •
edited
Loading

Description

This PR for fix bug "when opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks."

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang utchoang marked this pull request as draft March 8, 2021 06:48
This was referenced Mar 8, 2021
Merged
Merged
This was referenced Mar 8, 2021
Merged
Merged
Merged
Merged
Merged
Merged
@utchoang
Copy link
Author

@blueorangutan ui

@utchoang utchoang marked this pull request as ready for review March 16, 2021 07:40
@utchoang utchoang mentioned this pull request Mar 16, 2021
Closed
@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

1 similar comment
@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4762 (SL-JID-30)

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4762 (SL-JID-29)

@rohityadavcloud rohityadavcloud added this to the 4.15.1.0 milestone Mar 17, 2021
@rohityadavcloud
Copy link
Member

@utchoang do you want this PR merged, as I see other PRs related to UI (asking if this one has additional changes or the other UI related PRs already address issues)?

@utchoang
Copy link
Author

@rhtyd It can be merged if approved. Currently, I have separated PR so it is not relevant anymore.

@utchoang utchoang changed the title UI: Fix all issues from the archived primate repo UI: Auto-focus input, form Mar 18, 2021
@rohityadavcloud
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4762 (SL-JID-53)

@rohityadavcloud rohityadavcloud requested review from Pearl1594 and davidjumani and removed request for Pearl1594 March 24, 2021 07:08
davidjumani
davidjumani reviewed Mar 24, 2021
View reviewed changes
ui/src/views/AutogenView.vue
@@ -770,6 +778,16 @@ export default {
this.fillEditFormFieldValues()
}
},
getFirstIndexFocus () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjumani What's wrong with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good fix!

@davidjumani
Copy link
Contributor

@utchoang Could you also add the autofocus to EditVM and ScaleVM

@davidjumani
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4762 (SL-JID-65)

davidjumani
davidjumani approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested LGTM!

@rohityadavcloud rohityadavcloud merged commit 6428780 into apache:4.15 Mar 29, 2021
@utchoang utchoang deleted the feature/fix-issue-archive-primate branch March 30, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@davidjumani davidjumani davidjumani approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@shwstppr shwstppr Awaiting requested review from shwstppr

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

Assignees

@davidjumani davidjumani

Labels
None yet
Projects
None yet
Milestone
4.15.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@utchoang @blueorangutan @rohityadavcloud @davidjumani