-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Moves fetchdata() to the created() #4811
UI: Moves fetchdata() to the created() #4811
Conversation
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S] |
@utchoang will this offer any performance improvement? I hope we are not accessing/manipulating DOM elements in any of the fetchData methods |
@shwstppr Yes. In apache/cloudstack-primate#719 then move fetchData to created from mounted to reduce wait time for API calls since the data has been created but the page has not yet been rendered |
@utchoang what are the pros and cons of using one vs the other? |
@rhtyd When the component is initialized, fetching data from the backend at |
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did a quick round of testing
Forms appear to load a bit sooner
@utchoang can you fix the conflict against latest 4.15 branch |
@utchoang can you fix the conflict? |
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM proxing David's testing/review
UI build: ✔️ |
Description
This PR to move fetchData() to created() insteadof mount()
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?