Deprecate the use of datafusion_sql::ResolvedTableReference and TableReference
#14365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
commented
Jan 29, 2025
| #[deprecated( | ||
| since = "45.0.0", | ||
| note = "use datafusion_common::{ResolvedTableReference, TableReference}" | ||
| )] | ||
| pub use datafusion_common::{ResolvedTableReference, TableReference}; |
There was a problem hiding this comment.
I don't really know why this is publically re-exported but there is no reason to use it over what is in datafusion-common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Noticed while working on #14364 with @logan-keede
datafusion-sqlpublically re-exports stuff from datafusion_common:Which can then lead to unecessary explicit dependencies in Cargo.toml
What changes are included in this PR?
pub usedatafusion-sqlAre these changes tested?
By CI/ compiler
Are there any user-facing changes?