Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37533][CI] Reduce the stale PR github action timeouts #26336

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

tomncooper
Copy link
Contributor

FLINK-37026 enabled the Stale PR GitHub Action and this has been running successfully for several months, labelling PRs older than 6 months as "stale".

The initial time-outs for the Stale PR action were 6 months inactive with 3 further months of no action before closing. This was done to give time for PR authors to react to the new action. However, during the discussion it was suggested that 3 months inactive with 1 month to respond was the typical configuration used on other Apache projects and should also be used for Flink. It was decided to start with longer time-outs and move to the standard ones once the stability of the action was confirmed.

Now that the action has been running for some time with no issues, we should reduce the time-outs to the proposed Apache standard configuration (90 days inactive with 30 to respond). This will allow us to start clearing the oldest stale PRs.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 21, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…typical apache values (90 days inactive with 30 to respond)

Signed-off-by: Thomas Cooper <[email protected]>
@tomncooper tomncooper force-pushed the stale-pr-action-timeout branch from b4cef09 to 8374d7a Compare March 24, 2025 10:32
@tomncooper tomncooper changed the title [FLINK-37533][CI] Reduce the stale PR github action timouts [FLINK-37533][CI] Reduce the stale PR github action timeouts Mar 24, 2025
Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good and in line with the community decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants