SOLR-17631: Upgrade main to Lucene 10.x #3053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor, more scorerSupplier() fixes
…tor, more scorerSupplier() fixes
github-actions
bot
added
dependencies
cpoerschke
reviewed
Jan 24, 2025
Comment on lines
575
to
577
| public int docID() { | ||
| return docId; | ||
| } |
There was a problem hiding this comment.
Likely this can be removed, haven't tried it yet though.
Suggested change
| public int docID() { | |
| return docId; | |
| } |
cpoerschke
reviewed
Jan 24, 2025
Comment on lines
479
to
481
| public int docID() { | ||
| return docid; | ||
| } |
There was a problem hiding this comment.
Suggested change
| public int docID() { | |
| return docid; | |
| } |
cpoerschke
reviewed
Jan 31, 2025
Comment on lines
+148
to
+149
| assertEquals("1", searcher.storedFields().document(hits.scoreDocs[0].doc).get("id")); | ||
| assertEquals("0", searcher.storedFields().document(hits.scoreDocs[1].doc).get("id")); |
There was a problem hiding this comment.
Elsewhere outside of modules/ltr similar changes are needed too, #3149 proposes to separately replace.
…ne-10 Resolved Conflicts: solr/core/src/java/org/apache/solr/schema/DenseVectorField.java solr/core/src/test/org/apache/solr/core/TestCodecSupport.java
github-actions
bot
added
documentation
cpoerschke
reviewed
Feb 4, 2025
| @@ -603,7 +566,7 @@ protected Integer getNumberOfGroups() { | |||
| protected void populateScoresIfNecessary() throws IOException { | |||
| if (needScores) { | |||
| for (GroupDocs<?> groups : result.groups) { | |||
| TopFieldCollector.populateScores(groups.scoreDocs, searcher, query); | |||
| TopFieldCollector.populateScores(groups.scoreDocs(), searcher, query); | |||
There was a problem hiding this comment.
Just leaving a note here from investigating the grouping-related test failures, the filling in of the scores here does not influence the maxScore of a group and that seems to be wrong (always 1 possibly?) and so the groups are ordered wrongly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOLR-17631
Upgrade main to Lucene 10.x
Right now, I've fixed all compilation issues with core and test modules. Other modules still don't compile.
On the tests front, I've fixed a few tests. There are the tests that still fail: