-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17631: Upgrade main to Lucene 10.x #3053
Open
chatman
wants to merge
34
commits into
main
Choose a base branch
from
ishan/upgrade-to-lucene-10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 27 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
c22cfaa
WIP: Upgrading to Lucene 10
822d562
Removed dependency on TimeLimitingCollector
noblepaul c29bdeb
Removed the deprecated methods
noblepaul 8c9e9ed
Removed dependency on deprecated TopDocCollector
noblepaul f4b8b16
Moved setRewriteMethod() to constructor, replaced scorer() with score…
38a22d4
Replaced some more scorer() with scorerSupplier()
d4770a5
Changed rewrite method signature, added DV skip to FieldInfo construc…
705fe9b
Changed rewrite method signature, added DV skip to FieldInfo construc…
8b24db8
More fixes
7ec4b98
Removing deprecated method getTermVectors(int docID)
5dcff09
Removed TopScoreDocsCollector.create() and replaced with manager's ne…
d94b22f
Deal with removal of TopFieldCollector.create()
5c9dbf0
Removed dependencies on deprecated TimeLimitingCollector
noblepaul 9bb7397
removed deprecated methods
noblepaul 7f2a77b
Fixed deprecated methods
noblepaul 6224d6a
Fixed syntax errors
noblepaul 18ec6ea
Fixed syntax errors
noblepaul 4c141a6
Test compilation fixes
f490667
Adding our own scorer supplier
f5df6c7
bulk scorer modified
noblepaul e1fe99f
bulk scorer modified
noblepaul bcd4815
Don't close a stream during request parsing
dfead62
Fixing scorer issues with range queries, thereby passing ConvertedLeg…
a6ede24
Fixing SortedSetDocValues.NO_MORE_ORDS removal issue, fixed SolrIndex…
20eb534
More improper ordinals handling
266dae8
More ords handling fixed, passing TestJsonFacets now
c723c4d
Use match all docs for null filter
noblepaul f98f703
remove or tweak ScoreAndDoc use
cpoerschke 494b6b4
make solr/modules/ltr/src/java compile
cpoerschke f9c3af4
make solr/modules/*/src/java compile (mostly)
cpoerschke fe548f7
make solr/modules/ltr/src/test compile
cpoerschke 5fdc900
Merge remote-tracking branch 'origin/main' into ishan/upgrade-to-luce…
cpoerschke 96abdce
./gradlew resolveAndLockAll --write-locks
cpoerschke c246d7f
better merge conflict resolution for TestCodecSupport.java
cpoerschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -1755,7 +1755,6 @@ protected static class ScoreAndDoc extends Scorable { | |||||||
this.score = score; | ||||||||
} | ||||||||
|
||||||||
@Override | ||||||||
public int docID() { | ||||||||
return docid; | ||||||||
} | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this can be removed, haven't tried it yet though.
Suggested change
|
||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
links: