Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace babashka #784

Merged
merged 1 commit into from
May 15, 2023
Merged

feat: replace babashka #784

merged 1 commit into from
May 15, 2023

Conversation

acidghost
Copy link
Contributor

Summary

The plugin at https://github.com/fredZen/asdf-babashka is largely unmaintained.

It's not working on Apple Silicon macOS and the PRs have not been acknowledged for months (fredZen/asdf-babashka#3).

As noted by the author of babashka (fredZen/asdf-babashka#3 (comment)), there's a fork of the plugin (https://github.com/pitch-io/asdf-babashka) that is actively used and maintained.

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@acidghost acidghost requested a review from a team as a code owner March 22, 2023 10:07
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes will also need to be made to the entry in the README table for this plugin.

Edit: See this row in the README needs updating as well

image

@jthegedus jthegedus merged commit 926cd93 into asdf-vm:master May 15, 2023
@acidghost acidghost deleted the patch-1 branch May 15, 2023 07:13
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants