Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for this.action.disposalAction is not a function #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javaskript
Copy link

@javaskript javaskript commented Oct 24, 2018

Fixes issues #12 , #13 , and #15

This change fixes issues awaw00#12 , awaw00#13 , and awaw00#15
@javaskript javaskript changed the title Fix for Issue issues #12 , #13 , and #15 Fix for this.action.disposalAction is not a function Oct 24, 2018
@gilbertohasnofb
Copy link

@awaw00 Could you consider merging this and make a new release to include the fix via Atom's own package manager?

@javaskript
Copy link
Author

This changed fixed the error for me, Thanks.

You're welcome! This is actually my first bug fix commit ever on GitHub. Although a minor issue, I'm happy that it fixed the issue.

@dhafer94
Copy link

dhafer94 commented Jul 3, 2020

@Dazars Hello there. Check out the error code you got from your IDE..for me it was Atom. It told me

this:TypeError:this.action.disposalAction is not a function

at Object._paneItemChanged (file:///C:/Users/Ivan Lopez/.atom/packages/autoclose/lib/autoclose.coffee:39:29)
...bla bla bla...
Copy the file path and paste it on your file explorer search bar. It should take you to the 'autoclose' file. Open it and make the changes you see above on line 29 and 39. Change from if @action then @action.disposalAction() to if @action then @action.dispose()

I hope this helps!

Thank you for this it helped me, I spent a lot of time scrolling through bunch of stuff that I don't yet know , thanks again for this :)

@Japanmavani
Copy link

@Dazars Hello there. Check out the error code you got from your IDE..for me it was Atom. It told me

this:TypeError:this.action.disposalAction is not a function

at Object._paneItemChanged (file:///C:/Users/Ivan Lopez/.atom/packages/autoclose/lib/autoclose.coffee:39:29)
...bla bla bla...
Copy the file path and paste it on your file explorer search bar. It should take you to the 'autoclose' file. Open it and make the changes you see above on line 29 and 39. Change from if @action then @action.disposalAction() to if @action then @action.dispose()

I hope this helps!

I am also new in this. But I have question how you know what to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.