chore: enable lint on tests for api, interactions, predictions, pubsub packages #13547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. api 2. interactions 3. predictions 4. pubsub
david-mcafee
approved these changes
Jun 27, 2024
| @@ -229,7 +233,7 @@ export class FakeWebSocketInterface { | |||
| /** | |||
| * Send a data message | |||
| */ | |||
| async sendDataMessage(data: {}) { | |||
| async sendDataMessage(data: object) { | |||
There was a problem hiding this comment.
Is this right? Can data be a string?
There was a problem hiding this comment.
Noticeably this function is not even used by the tests.
ashika112
reviewed
Jun 28, 2024
| @@ -370,7 +366,7 @@ export async function replaceConstant( | |||
| replacementValue: any, | |||
| testFn: () => Promise<void>, | |||
| ) { | |||
| const initialValue = constants[name]; | |||
| const initialValue = (constants as any)[name]; | |||
There was a problem hiding this comment.
why cast as any than their actual types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.