chore: enable lint on tests for api, interactions, predictions, pubsub packages

.eslintrc.js

@@ -35,13 +35,9 @@ module.exports = {
 		'setupTests.ts',
 		'jest.setup.*',
 		'jest.config.*',
-		'packages/api/__tests__',
 		'packages/api-graphql/__tests__',
 		'packages/datastore/__tests__',
 		'packages/datastore-storage-adapter/__tests__',
-		'packages/interactions/__tests__',
-		'packages/predictions/__tests__',
-		'packages/pubsub/__tests__',
 	],
 	rules: {
 		camelcase: [

packages/api/__tests__/API.test.ts

@@ -1,15 +1,8 @@
-import { ResourcesConfig } from 'aws-amplify';
 import { InternalGraphQLAPIClass } from '@aws-amplify/api-graphql/internals';
-import { generateClient, CONNECTION_STATE_CHANGE } from '@aws-amplify/api';
 import { AmplifyClassV6 } from '@aws-amplify/core';
-// import { runWithAmplifyServerContext } from 'aws-amplify/internals/adapter-core';
 
-const serverManagedFields = {
-	id: 'some-id',
-	owner: 'wirejobviously',
-	createdAt: new Date().toISOString(),
-	updatedAt: new Date().toISOString(),
-};
+import { CONNECTION_STATE_CHANGE, generateClient } from '@aws-amplify/api';
+// import { runWithAmplifyServerContext } from 'aws-amplify/internals/adapter-core';
 
 describe('API generateClient', () => {
 	afterEach(() => {

packages/interactions/__tests__/lex-v1/AWSLexProvider.test.ts

@@ -6,17 +6,21 @@ import {
 	PostTextCommand,
 	PostTextCommandOutput,
 } from '@aws-sdk/client-lex-runtime-service';
-import { lexProvider } from '../../src/lex-v1/AWSLexProvider';
 import { fetchAuthSession } from '@aws-amplify/core';
 
+import { lexProvider } from '../../src/lex-v1/AWSLexProvider';
+import { InteractionsOnCompleteCallback } from '../../src/types/Interactions';
+
 jest.mock('@aws-amplify/core');
 
 (global as any).Response = class Response {
-	arrayBuffer(blob: Blob) {
+	arrayBuffer() {
 		return Promise.resolve(new ArrayBuffer(0));
 	}
 };
 
+type AWSLexProvider = typeof lexProvider;
+
 // mock stream response
 const createBlob = () => {
 	return new Blob();
@@ -47,7 +51,7 @@ const credentials = {
 
 const mockFetchAuthSession = fetchAuthSession as jest.Mock;
 
-LexRuntimeServiceClient.prototype.send = jest.fn((command, callback) => {
+LexRuntimeServiceClient.prototype.send = jest.fn(command => {
 	if (command instanceof PostTextCommand) {
 		if (command.input.inputText === 'done') {
 			const result = {
@@ -58,18 +62,21 @@ LexRuntimeServiceClient.prototype.send = jest.fn((command, callback) => {
 					m2: 'done',
 				},
 			};
+
 			return Promise.resolve(result);
 		} else if (command.input.inputText === 'error') {
 			const result = {
 				message: 'echo:' + command.input.inputText,
 				dialogState: 'Failed',
 			};
+
 			return Promise.resolve(result);
 		} else {
 			const result = {
 				message: 'echo:' + command.input.inputText,
 				dialogState: 'ElicitSlot',
 			};
+
 			return Promise.resolve(result);
 		}
 	} else if (command instanceof PostContentCommand) {
@@ -78,7 +85,7 @@ LexRuntimeServiceClient.prototype.send = jest.fn((command, callback) => {
 			'audio/x-l16; sample-rate=16000; channel-count=1'
 		) {
 			const bot = command.input.botName as string;
-			const [botName, status] = bot.split(':');
+			const [_botName, status] = bot.split(':');
 
 			if (status === 'done') {
 				// we add the status to the botName
@@ -92,20 +99,23 @@ LexRuntimeServiceClient.prototype.send = jest.fn((command, callback) => {
 					},
 					audioStream: createBlob(),
 				};
+
 				return Promise.resolve(result);
 			} else if (status === 'error') {
 				const result = {
 					message: 'voice:echo:' + command.input.botName,
 					dialogState: 'Failed',
 					audioStream: createBlob(),
 				};
+
 				return Promise.resolve(result);
 			} else {
 				const result = {
 					message: 'voice:echo:' + command.input.botName,
 					dialogState: 'ElicitSlot',
 					audioStream: createBlob(),
 				};
+
 				return Promise.resolve(result);
 			}
 		} else {
@@ -119,20 +129,23 @@ LexRuntimeServiceClient.prototype.send = jest.fn((command, callback) => {
 					},
 					audioStream: createBlob(),
 				};
+
 				return Promise.resolve(result);
 			} else if (command.input.inputStream === 'error') {
 				const result = {
 					message: 'echo:' + command.input.inputStream,
 					dialogState: 'Failed',
 					audioStream: createBlob(),
 				};
+
 				return Promise.resolve(result);
 			} else {
 				const result = {
 					message: 'echo:' + command.input.inputStream,
 					dialogState: 'ElicitSlot',
 					audioStream: createBlob(),
 				};
+
 				return Promise.resolve(result);
 			}
 		}
@@ -146,7 +159,7 @@ afterEach(() => {
 describe('Interactions', () => {
 	// send text and audio message to bot
 	describe('send API', () => {
-		let provider;
+		let provider: AWSLexProvider;
 
 		beforeEach(() => {
 			mockFetchAuthSession.mockReturnValue(credentials);
@@ -266,6 +279,7 @@ describe('Interactions', () => {
 				provider.sendMessage(botConfig.BookTrip, {
 					content: createBlob(),
 					options: {
+						// @ts-expect-error for testing messageType mismatches content type
 						messageType: 'text',
 					},
 				}),
@@ -274,6 +288,7 @@ describe('Interactions', () => {
 			// obj voice in wrong format
 			await expect(
 				provider.sendMessage(botConfig.BookTrip, {
+					// @ts-expect-error for testing messageType mismatches content type
 					content: 'Hi',
 					options: {
 						messageType: 'voice',
@@ -285,8 +300,8 @@ describe('Interactions', () => {
 
 	// attach 'onComplete' callback to bot
 	describe('onComplete API', () => {
-		const callback = (err, confirmation) => {};
-		let provider;
+		const callback = jest.fn();
+		let provider: AWSLexProvider;
 
 		beforeEach(() => {
 			mockFetchAuthSession.mockReturnValue(credentials);
@@ -298,34 +313,32 @@ describe('Interactions', () => {
 		});
 
 		test('Configure onComplete callback for a configured bot successfully', () => {
-			expect(() =>
-				provider.onComplete(botConfig.BookTrip, callback),
-			).not.toThrow();
+			expect(() => {
+				provider.onComplete(botConfig.BookTrip, callback);
+			}).not.toThrow();
 			expect.assertions(1);
 		});
 	});
 
 	// test if 'onComplete' callback is fired for different actions
 	describe('reportBotStatus API', () => {
 		jest.useFakeTimers();
-		let provider;
+		let provider: AWSLexProvider;
 
-		let inProgressResp;
-		let completeSuccessResp;
-		let completeFailResp;
+		let inProgressResp: PostTextCommandOutput;
+		let completeSuccessResp: PostTextCommandOutput;
+		let completeFailResp: PostTextCommandOutput;
 
-		let inProgressCallback;
-		let completeSuccessCallback;
-		let completeFailCallback;
+		let inProgressCallback: InteractionsOnCompleteCallback;
+		let completeSuccessCallback: InteractionsOnCompleteCallback;
+		let completeFailCallback: InteractionsOnCompleteCallback;
 
 		beforeEach(async () => {
 			mockFetchAuthSession.mockReturnValue(credentials);
 			provider = lexProvider;
 
 			// mock callbacks
-			inProgressCallback = jest.fn((err, confirmation) =>
-				fail(`callback shouldn't be called`),
-			);
+			inProgressCallback = jest.fn(() => fail(`callback shouldn't be called`));
 
 			completeSuccessCallback = jest.fn((err, confirmation) => {
 				expect(err).toEqual(undefined);
@@ -339,9 +352,9 @@ describe('Interactions', () => {
 				});
 			});
 
-			completeFailCallback = jest.fn((err, confirmation) =>
-				expect(err).toEqual(new Error('Bot conversation failed')),
-			);
+			completeFailCallback = jest.fn(err => {
+				expect(err).toEqual(new Error('Bot conversation failed'));
+			});
 
 			// mock responses
 			inProgressResp = (await provider.sendMessage(

packages/interactions/__tests__/lex-v1/apis/onComplete.test.ts

@@ -1,7 +1,6 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-import { v4 as uuid } from 'uuid';
 import { lexProvider } from '../../../src/lex-v1/AWSLexProvider';
 import { onComplete } from '../../../src/lex-v1/apis';
 import { generateRandomLexV1Config } from '../../testUtils/randomConfigGeneration';
@@ -27,7 +26,6 @@ describe('Interactions LexV1 API: onComplete', () => {
 	});
 
 	it('invokes provider onComplete API', () => {
-		const message = uuid();
 		const mockCallback = jest.fn();
 		onComplete({ botName: v1BotConfig.name, callback: mockCallback });
 		expect(mockLexProvider).toHaveBeenCalledTimes(1);
@@ -36,8 +34,8 @@ describe('Interactions LexV1 API: onComplete', () => {
 
 	it('rejects when bot config does not exist', async () => {
 		mockResolveBotConfig.mockReturnValue(undefined);
-		expect(() =>
-			onComplete({ botName: v1BotConfig.name, callback: jest.fn }),
-		).toThrow(InteractionsError);
+		expect(() => {
+			onComplete({ botName: v1BotConfig.name, callback: jest.fn });
+		}).toThrow(InteractionsError);
 	});
 });

packages/interactions/__tests__/lex-v1/apis/send.test.ts

@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 import { v4 as uuid } from 'uuid';
+
 import { lexProvider } from '../../../src/lex-v1/AWSLexProvider';
 import { send } from '../../../src/lex-v1/apis';
 import { generateRandomLexV1Config } from '../../testUtils/randomConfigGeneration';

packages/interactions/__tests__/lex-v1/utils/resolveBotConfig.test.ts

@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 import { Amplify } from '@aws-amplify/core';
+
 import {
 	generateRandomLexV1Config,
 	generateRandomLexV2Config,