Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): replace icons with text #6398

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix(amazonq): replace icons with text #6398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
610a3f7
fix(amazonq): replace icons with text
Jan 18, 2025
c407b0c
add changelog
Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-da5a775a-766c-4862-8cab-2bb0259acb2f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "/transform: replace icons in Transformation Hub with text"
}
28 changes: 9 additions & 19 deletions packages/amazonq/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,16 +319,14 @@
"group": "navigation@3"
},
{
"command": "aws.amazonq.transformationHub.summary.reveal",
"when": "view == aws.amazonq.transformationHub"
},
{
"command": "aws.amazonq.transformationHub.reviewChanges.reveal",
"when": "view == aws.amazonq.transformationHub"
"command": "aws.amazonq.showTransformationPlanInHub",
"when": "view == aws.amazonq.transformationHub",
"group": "navigation@4"
},
{
"command": "aws.amazonq.showTransformationPlanInHub",
"when": "view == aws.amazonq.transformationHub"
"command": "aws.amazonq.transformationHub.summary.reveal",
"when": "view == aws.amazonq.transformationHub",
"group": "navigation@5"
},
{
"command": "aws.amazonq.transformationHub.reviewChanges.acceptChanges",
Expand Down Expand Up @@ -568,11 +566,6 @@
"title": "%AWS.command.q.transform.showChangeSummary%",
"enablement": "gumby.isSummaryAvailable"
},
{
"command": "aws.amazonq.transformationHub.reviewChanges.reveal",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes show up automatically after downloading so this didn't do anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a dumb question but the aws.amazonq.transformationHub.reviewChanges.reveal command is used in startTransformByQ and transformationResultsViewProvider, does this removal affect anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question! This command is registered here:

aws-toolkit-vscode/packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts

Line 358 in 01351dd

vscode.commands.registerCommand('aws.amazonq.transformationHub.reviewChanges.reveal', async () => {

So as long as we keep that we are good. These few lines deleted here just remove a "View Proposed Changes" button that we used to have, since it's not useful because the proposed changes open automatically after downloading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh this makes sense, thank you!

"title": "%AWS.command.q.transform.showChanges%",
"enablement": "gumby.reviewState == InReview"
},
{
"command": "aws.amazonq.showTransformationPlanInHub",
"title": "%AWS.command.q.transform.showTransformationPlan%",
Expand Down Expand Up @@ -643,19 +636,16 @@
},
{
"command": "aws.amazonq.stopTransformationInHub",
"title": "Stop Transformation",
"icon": "$(stop)",
"title": "%AWS.command.q.transform.stopJobInHub%",
"enablement": "gumby.isStopButtonAvailable"
},
{
"command": "aws.amazonq.showPlanProgressInHub",
"title": "Show Transformation Status",
"icon": "$(checklist)"
"title": "%AWS.command.q.transform.viewJobProgress%"
},
{
"command": "aws.amazonq.showHistoryInHub",
"title": "Show Job Status",
"icon": "$(history)"
"title": "%AWS.command.q.transform.viewJobStatus%"
},
{
"command": "aws.amazonq.selectCustomization",
Expand Down
8 changes: 5 additions & 3 deletions packages/core/package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,11 @@
"AWS.command.codewhisperer.openReferencePanel": "Open Code Reference Log",
"AWS.command.q.transform.acceptChanges": "Accept",
"AWS.command.q.transform.rejectChanges": "Reject",
"AWS.command.q.transform.showChanges": "Show Proposed Changes",
"AWS.command.q.transform.showChangeSummary": "Show Transformation Summary",
"AWS.command.q.transform.showTransformationPlan": "Show Transformation Plan",
"AWS.command.q.transform.stopJobInHub": "Stop job",
"AWS.command.q.transform.viewJobProgress": "View job progress",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't clear until I saw the picture, but do we really need "View" as the prefix for all of these? Why not "Stop Job", "Job Progress" (or just Progress), "Status", "Plan", "Summary"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, right now in JB we have the "View", but can double check on this and revert in a future PR if we decide to go in that direction

Copy link
Contributor

@jpinkney-aws jpinkney-aws Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably just sync with a UX person quickly before merging, since its just a couple of string changes

"AWS.command.q.transform.viewJobStatus": "View job status",
"AWS.command.q.transform.showTransformationPlan": "View plan",
"AWS.command.q.transform.showChangeSummary": "View summary",
"AWS.command.threatComposer.createNew": "Create New Threat Composer File",
"AWS.command.threatComposer.newFile": "Threat Composer File",
"AWS.threatComposer.page.title": "{0} (Threat Composer)",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/codewhisperer/service/transformByQ/transformationHubViewProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export class TransformationHubViewProvider implements vscode.WebviewViewProvider
</style>
</head>
<body>
<p><b>Job Status</b></p>
<p><b>Transformation Status</b></p>
${
Object.keys(sessionJobHistory).length === 0
? `<p>${CodeWhispererConstants.nothingToShowMessage}</p>`
Expand Down
Loading
Loading