Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amazonq): replace icons with text #6398

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix(amazonq): replace icons with text #6398

merged 2 commits into from
Jan 21, 2025

Conversation

dhasani23
Copy link
Contributor

@dhasani23 dhasani23 commented Jan 18, 2025 •
edited
Loading

Problem

The multiple icons in the top right of our Transformation Hub were not easily visible or sufficiently clear to users.

Solution

Remove the icons, replacing them with a description of what the icon/button does.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested review from a team as code owners January 18, 2025 00:14
@github-actions GitHub Actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

dhasani23
dhasani23 commented Jan 18, 2025
View reviewed changes
packages/amazonq/package.json
@@ -568,11 +566,6 @@
"title": "%AWS.command.q.transform.showChangeSummary%",
"enablement": "gumby.isSummaryAvailable"
},
{
"command": "aws.amazonq.transformationHub.reviewChanges.reveal",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes show up automatically after downloading so this didn't do anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a dumb question but the aws.amazonq.transformationHub.reviewChanges.reveal command is used in startTransformByQ and transformationResultsViewProvider, does this removal affect anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question! This command is registered here:

aws-toolkit-vscode/packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts

Line 358 in 01351dd

vscode.commands.registerCommand('aws.amazonq.transformationHub.reviewChanges.reveal', async () => {

So as long as we keep that we are good. These few lines deleted here just remove a "View Proposed Changes" button that we used to have, since it's not useful because the proposed changes open automatically after downloading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh this makes sense, thank you!

@dhasani23
Copy link
Contributor Author

dhasani23 commented Jan 18, 2025 •
edited
Loading

/retryBuild

@dhasani23
Copy link
Contributor Author

image

@dhasani23
Copy link
Contributor Author

dhasani23 commented Jan 19, 2025 •
edited
Loading

CI / test macOS (18.x, stable) is resulting in ECONNRESET, but /retryBuild not working for some reason

jpinkney-aws
jpinkney-aws reviewed Jan 21, 2025
View reviewed changes
packages/core/package.nls.json
"AWS.command.q.transform.showChangeSummary": "Show Transformation Summary",
"AWS.command.q.transform.showTransformationPlan": "Show Transformation Plan",
"AWS.command.q.transform.stopJobInHub": "Stop job",
"AWS.command.q.transform.viewJobProgress": "View job progress",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't clear until I saw the picture, but do we really need "View" as the prefix for all of these? Why not "Stop Job", "Job Progress" (or just Progress), "Status", "Plan", "Summary"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, right now in JB we have the "View", but can double check on this and revert in a future PR if we decide to go in that direction

Copy link
Contributor

@jpinkney-aws jpinkney-aws Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably just sync with a UX person quickly before merging, since its just a couple of string changes

@dhasani23 dhasani23 merged commit e11c27d into aws:master Jan 21, 2025
25 of 26 checks passed
kevluu-aws pushed a commit to kevluu-aws/aws-toolkit-vscode that referenced this pull request Jan 23, 2025
@dhasani23 @kevluu-aws
fix(amazonq): replace icons with text (aws#6398)
3345e06 
## Problem

The multiple icons in the top right of our Transformation Hub were not
easily visible or sufficiently clear to users.

## Solution

Remove the icons, replacing them with a description of what the
icon/button does.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: David Hasani <[email protected]>
chungjac pushed a commit to chungjac/aws-toolkit-vscode that referenced this pull request Jan 24, 2025
@dhasani23 @chungjac
fix(amazonq): replace icons with text (aws#6398)
314e66f 
## Problem

The multiple icons in the top right of our Transformation Hub were not
easily visible or sufficiently clear to users.

## Solution

Remove the icons, replacing them with a description of what the
icon/button does.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: David Hasani <[email protected]>
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
@dhasani23 @s7ab059789
fix(amazonq): replace icons with text (aws#6398)
2c610f5 
## Problem

The multiple icons in the top right of our Transformation Hub were not
easily visible or sufficiently clear to users.

## Solution

Remove the icons, replacing them with a description of what the
icon/button does.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: David Hasani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinkney-aws jpinkney-aws jpinkney-aws approved these changes

@ntarakad-aws ntarakad-aws ntarakad-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhasani23 @jpinkney-aws @ntarakad-aws