Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Router V1 #210

Merged
merged 4 commits into from
Mar 18, 2025
Merged

Deprecate Router V1 #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fa5a9d
Move original router to deprecated folder
EndymionJkb Mar 17, 2025
ddef110
docs: update changelog and readme - also correct Cow Swap Fee Burner …
EndymionJkb Mar 17, 2025
97efc44
restore artifact
EndymionJkb Mar 17, 2025
07528d7
update addresses
EndymionJkb Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
#### V3

- Deprecated `20241205-v3-composite-liquidity-router`.
- Deprecated `20241205-v3-router`.

#### V2

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ Returns an object with all contracts from a deployment and their addresses.
| V3 Vault | [`20241204-v3-vault`](./v3/tasks/20241204-v3-vault) |
| V3 Weighted Pool | [`20241205-v3-weighted-pool`](./v3/tasks/20241205-v3-weighted-pool) |
| V3 Stable Pool | [`20241205-v3-stable-pool`](./v3/tasks/20241205-v3-stable-pool) |
| V3 Router | [`20241205-v3-router`](./v3/tasks/20241205-v3-router) |
| V3 Batch Router | [`20241205-v3-batch-router`](./v3/tasks/20241205-v3-batch-router) |
| V3 Buffer Router | [`20241205-v3-buffer-router`](./v3/tasks/20241205-v3-buffer-router) |
| V3 Vault Explorer | [`20241205-v3-vault-explorer`](./v3/tasks/20241205-v3-vault-explorer) |
Expand All @@ -137,6 +136,7 @@ Returns an object with all contracts from a deployment and their addresses.
| V3 MEV Capture Hook | [`20250212-v3-mev-capture-hook`](./v3/tasks/20250212-v3-mev-capture-hook) |
| V3 Protocol Fee Controller V2 | [`20250214-v3-protocol-fee-controller-v2`](./v3/tasks/20250214-v3-protocol-fee-controller-v2) |
| V3 Aggregator Router | [`20250218-v3-aggregator-router`](./v3/tasks/20250218-v3-aggregator-router) |
| V3 Cow Swap Fee Burner | [`20250221-v3-cow-swap-fee-burner`](./v3/tasks/20250221-v3-cow-swap-fee-burner) |
| V3 Protocol Fee Sweeper | [`20250228-v3-protocol-fee-sweeper`](./v3/tasks/20250228-v3-protocol-fee-sweeper) |
| V3 Router V2 | [`20250307-v3-router-v2`](./v3/tasks/20250307-v3-router-v2) |
| V3 Liquidity Bootstrapping Pool | [`20250307-v3-liquidity-bootstrapping-pool`](./v3/tasks/20250307-v3-liquidity-bootstrapping-pool) |
Expand Down Expand Up @@ -228,4 +228,4 @@ Go to each deprecated deployment's readme file to learn more about why it is dep
| Composable Stable Pools V5 (ZKEVM) | [`20230711-zkevm-composable-stable-pool-v5`](./v2/deprecated/20230711-zkevm-composable-stable-pool-v5) |
| Stakeless Gauge Checkpointer | [`20230731-stakeless-gauge-checkpointer`](./v2/deprecated/20230731-stakeless-gauge-checkpointer) |
| V3 Composite Liquidity Router | [`20241205-v3-composite-liquidity-router`](./v3/deprecated/20241205-v3-composite-liquidity-router) |
| V3 Cow Swap Fee Burner | [`20250221-v3-cow-swap-fee-burner`](./v3/tasks/20250221-v3-cow-swap-fee-burner) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it supposed to be deleted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's moved up to the live task section. It was mistakenly added to the deprecated list; this is correcting it.

| V3 Router | [`20241205-v3-router`](./v3/deprecated/20241205-v3-router) |
2 changes: 1 addition & 1 deletion addresses/arbitrum.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,7 @@
"address": "0x0f08eEf2C785AA5e7539684aF04755dEC1347b7c"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-stable-pool": {
Expand Down
2 changes: 1 addition & 1 deletion addresses/base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@
"address": "0x76578ecf9a141296Ec657847fb45B0585bCDa3a6"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-stable-pool": {
Expand Down
2 changes: 1 addition & 1 deletion addresses/gnosis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@
"address": "0x84813aA3e079A665C0B80F944427eE83cBA63617"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-stable-pool": {
Expand Down
2 changes: 1 addition & 1 deletion addresses/mainnet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,7 +1442,7 @@
"address": "0x5C6fb490BDFD3246EB0bB062c168DeCAF4bD9FDd"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-stable-pool": {
Expand Down
2 changes: 1 addition & 1 deletion addresses/sepolia.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@
"address": "0x0BF61f706105EA44694f2e92986bD01C39930280"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-stable-pool": {
Expand Down
2 changes: 1 addition & 1 deletion v3/deprecated/20241205-v3-composite-liquidity-router/test/task.fork.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Contract } from 'ethers';
import { SignerWithAddress } from '@nomiclabs/hardhat-ethers/signers';
import { fp } from '@helpers/numbers';

describeForkTest.skip('CompositeLiquidityRouter-V3', 'mainnet', 21336200, function () {
describeForkTest('CompositeLiquidityRouter-V3', 'mainnet', 21336200, function () {
let task: Task;
let compositeLiquidityRouter: Contract;
let wethSigner: SignerWithAddress, alice: SignerWithAddress;
Expand Down
0 ...s/20241205-v3-router/artifact/Router.json → ...d/20241205-v3-router/artifact/Router.json
View file
Open in desktop
File renamed without changes.
0 ...20241205-v3-router/build-info/Router.json → ...20241205-v3-router/build-info/Router.json
View file
Open in desktop
File renamed without changes.
0 v3/tasks/20241205-v3-router/index.ts → v3/deprecated/20241205-v3-router/index.ts
View file
Open in desktop
File renamed without changes.
0 v3/tasks/20241205-v3-router/input.ts → v3/deprecated/20241205-v3-router/input.ts
View file
Open in desktop
File renamed without changes.
0 ...s/20241205-v3-router/output/arbitrum.json → ...d/20241205-v3-router/output/arbitrum.json
View file
Open in desktop
File renamed without changes.
0 v3/tasks/20241205-v3-router/output/base.json → ...cated/20241205-v3-router/output/base.json
View file
Open in desktop
File renamed without changes.
0 ...sks/20241205-v3-router/output/gnosis.json → ...ted/20241205-v3-router/output/gnosis.json
View file
Open in desktop
File renamed without changes.
0 ...ks/20241205-v3-router/output/mainnet.json → ...ed/20241205-v3-router/output/mainnet.json
View file
Open in desktop
File renamed without changes.
0 ...ks/20241205-v3-router/output/sepolia.json → ...ed/20241205-v3-router/output/sepolia.json
View file
Open in desktop
File renamed without changes.
6 changes: 6 additions & 0 deletions v3/tasks/20241205-v3-router/readme.md → v3/deprecated/20241205-v3-router/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# 2024-12-05 - V3 Router

> ⚠️ **DEPRECATED: do not use** ⚠️
>
> This router was superseded by this [updated version](../../tasks/20250307-v3-router-v2/).

Note that the original router is still *safe* to use.

Base Router deployment for V3.
Contains `Router` for basic, single step operations (e.g., pool initialization, add, remove, swap).

Expand Down
2 changes: 1 addition & 1 deletion ...asks/20241205-v3-router/test/task.fork.ts → ...ated/20241205-v3-router/test/task.fork.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import * as expectEvent from '@helpers/expectEvent';
import { RouterDeployment } from '../input';
import { setBalance } from '@nomicfoundation/hardhat-network-helpers';

describeForkTest('Router-V3', 'mainnet', 21336200, function () {
describeForkTest.skip('Router-V3', 'mainnet', 21336200, function () {
let task: Task;
let router: Contract, permit2: Contract;
let factory: Contract, pool: Contract;
Expand Down
Loading