Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Router V1 #210

Merged
merged 4 commits into from
Mar 18, 2025
Merged

Conversation

EndymionJkb
Copy link
Collaborator

Deprecate Router V1 in favor of V2. The readme notes that the V1 Router is still safe to use, it's just not the latest, which saves the sender on initialization to enable single-LP pools like LBPs.

This also fixes an error in the readme. Apparently the Cow Swap Fee Burner deployment was added to the deprecated instead of the active list.

Deprecating old tasks checklist:

  • Old task was moved to deprecated/ directory
  • Deployments README is updated: old task is moved to the 'deprecated' section, and links are updated with the deprecated/ prefix
  • Old task imports in index.ts, input.ts and fork tests are updated
  • Old task README is updated with a warning sign, a link to the replacement task and a short description

Issue Resolution

Closes #199

Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on the V3 Cow Swap Fee Burner, but LGTM!

@@ -228,4 +228,4 @@ Go to each deprecated deployment's readme file to learn more about why it is dep
| Composable Stable Pools V5 (ZKEVM) | [`20230711-zkevm-composable-stable-pool-v5`](./v2/deprecated/20230711-zkevm-composable-stable-pool-v5) |
| Stakeless Gauge Checkpointer | [`20230731-stakeless-gauge-checkpointer`](./v2/deprecated/20230731-stakeless-gauge-checkpointer) |
| V3 Composite Liquidity Router | [`20241205-v3-composite-liquidity-router`](./v3/deprecated/20241205-v3-composite-liquidity-router) |
| V3 Cow Swap Fee Burner | [`20250221-v3-cow-swap-fee-burner`](./v3/tasks/20250221-v3-cow-swap-fee-burner) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it supposed to be deleted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's moved up to the live task section. It was mistakenly added to the deprecated list; this is correcting it.

@EndymionJkb EndymionJkb merged commit 9800d4d into master Mar 18, 2025
42 checks passed
@EndymionJkb EndymionJkb deleted the deployment-preparation/deprecate-router-v1 branch March 18, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Router V1
2 participants