Deprecate Router V1 #210
Merged
Deprecate Router V1 #210
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
joaobrunoah
approved these changes
Mar 18, 2025
| @@ -228,4 +228,4 @@ Go to each deprecated deployment's readme file to learn more about why it is dep | |||
| | Composable Stable Pools V5 (ZKEVM) | [`20230711-zkevm-composable-stable-pool-v5`](./v2/deprecated/20230711-zkevm-composable-stable-pool-v5) | | |||
| | Stakeless Gauge Checkpointer | [`20230731-stakeless-gauge-checkpointer`](./v2/deprecated/20230731-stakeless-gauge-checkpointer) | | |||
| | V3 Composite Liquidity Router | [`20241205-v3-composite-liquidity-router`](./v3/deprecated/20241205-v3-composite-liquidity-router) | | |||
| | V3 Cow Swap Fee Burner | [`20250221-v3-cow-swap-fee-burner`](./v3/tasks/20250221-v3-cow-swap-fee-burner) | | |||
There was a problem hiding this comment.
Is it supposed to be deleted?
There was a problem hiding this comment.
It's moved up to the live task section. It was mistakenly added to the deprecated list; this is correcting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate Router V1 in favor of V2. The readme notes that the V1 Router is still safe to use, it's just not the latest, which saves the sender on initialization to enable single-LP pools like LBPs.
This also fixes an error in the readme. Apparently the Cow Swap Fee Burner deployment was added to the deprecated instead of the active list.
Deprecating old tasks checklist:
deprecated/directoryREADMEis updated: old task is moved to the 'deprecated' section, and links are updated with thedeprecated/prefixindex.ts,input.tsand fork tests are updatedREADMEis updated with a warning sign, a link to the replacement task and a short descriptionIssue Resolution
Closes #199