Deployment preparation: Stable Pool V2 #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaobrunoah
previously approved these changes
Mar 18, 2025
| @@ -7,7 +7,7 @@ import { ONES_BYTES32, ZERO_ADDRESS } from '@helpers/constants'; | |||
| import { bn, fp } from '@helpers/numbers'; | |||
| import { StablePoolDeployment } from '../input'; | |||
|
|
|||
| describeForkTest('StablePool-V3', 'mainnet', 21336200, function () { | |||
| describeForkTest.skip('StablePool-V3', 'mainnet', 21336200, function () { | |||
There was a problem hiding this comment.
Nice to know that we need to actively skip the tests inside the deprecated folder. I wonder if there's a way to automatically ignore these tests.
There was a problem hiding this comment.
We'd have to special-case it in the scripts, which we generalized to find everything (making other things easier). It's possible, but since deprecation isn't that common, maybe it's not too onerous. (Come to think of it, we should probably add that to the deprecation checklist then, which we just changed.)
Technically they should all still work; I believe we skip them mainly to save CI time.
# Conflicts: # CHANGELOG.md # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment preparation: Stable Pool V2
Deploy V2 of the Stable Pool, which raises the amp factor limit and allows the swap fee manager to change the amp factor without governance intervention.
build-info: balancer/balancer-v3-monorepo@e1ae7f0
Note that the readme issue with the Cow Fee Burner in the wrong place is addressed in PR #210.
Deployment preparation tasks checklist:
READMEis updated with the new task name and linkREADMEhas a description and links to the artifactsbuild-infois updated with artifacts compiled at the specified commitbuild-infoDeprecating old tasks checklist:
deprecated/directoryREADMEis updated: old task is moved to the 'deprecated' section, and links are updated with thedeprecated/prefixindex.ts,input.tsand fork tests are updatedREADMEis updated with a warning sign, a link to the replacement task and a short descriptionCode checklist:
master, or there's a description of how to mergeIssue Resolution
Closes #184