Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment preparation: Stable Pool V2 #212

Merged
merged 4 commits into from
Mar 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@

- Deprecated `20241205-v3-composite-liquidity-router`.
- Deprecated `20241205-v3-router`.
- Deprecated `20241205-v3-stable-pool`.

#### V2

Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ Returns an object with all contracts from a deployment and their addresses.
| Fraxtal Root Gauge, for veBAL voting | [`20240522-fraxtal-root-gauge-factory`](./v2/tasks/20240522-fraxtal-root-gauge-factory) |
| V3 Vault | [`20241204-v3-vault`](./v3/tasks/20241204-v3-vault) |
| V3 Weighted Pool | [`20241205-v3-weighted-pool`](./v3/tasks/20241205-v3-weighted-pool) |
| V3 Stable Pool | [`20241205-v3-stable-pool`](./v3/tasks/20241205-v3-stable-pool) |
| V3 Batch Router | [`20241205-v3-batch-router`](./v3/tasks/20241205-v3-batch-router) |
| V3 Buffer Router | [`20241205-v3-buffer-router`](./v3/tasks/20241205-v3-buffer-router) |
| V3 Vault Explorer | [`20241205-v3-vault-explorer`](./v3/tasks/20241205-v3-vault-explorer) |
Expand All @@ -140,6 +139,7 @@ Returns an object with all contracts from a deployment and their addresses.
| V3 Protocol Fee Sweeper | [`20250228-v3-protocol-fee-sweeper`](./v3/tasks/20250228-v3-protocol-fee-sweeper) |
| V3 Router V2 | [`20250307-v3-router-v2`](./v3/tasks/20250307-v3-router-v2) |
| V3 Liquidity Bootstrapping Pool | [`20250307-v3-liquidity-bootstrapping-pool`](./v3/tasks/20250307-v3-liquidity-bootstrapping-pool) |
| V3 Stable Pool V2 | [`20250324-v3-stable-pool-v2`](./v3/tasks/20250324-v3-stable-pool-v2) |

## Scripts

Expand Down Expand Up @@ -229,3 +229,4 @@ Go to each deprecated deployment's readme file to learn more about why it is dep
| Stakeless Gauge Checkpointer | [`20230731-stakeless-gauge-checkpointer`](./v2/deprecated/20230731-stakeless-gauge-checkpointer) |
| V3 Composite Liquidity Router | [`20241205-v3-composite-liquidity-router`](./v3/deprecated/20241205-v3-composite-liquidity-router) |
| V3 Router | [`20241205-v3-router`](./v3/deprecated/20241205-v3-router) |
| V3 Stable Pool | [`20241205-v3-stable-pool`](./v3/deprecated/20241205-v3-stable-pool) |
2 changes: 1 addition & 1 deletion addresses/arbitrum.json
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@
"address": "0xC8B43aa1C60c4caE0ACBf3db9C79e407E09b13dA"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-vault-explorer": {
Expand Down
2 changes: 1 addition & 1 deletion addresses/base.json
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@
"address": "0xd64da6d2f39Afe68479e68c5bAaEA81FdA39C360"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-vault-explorer": {
Expand Down
2 changes: 1 addition & 1 deletion addresses/gnosis.json
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@
"address": "0x5006082D252c6315C3A83BD621927551a20F3b44"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-vault-explorer": {
Expand Down
2 changes: 1 addition & 1 deletion addresses/mainnet.json
Original file line number Diff line number Diff line change
Expand Up @@ -1456,7 +1456,7 @@
"address": "0x89Ef89Fd9a6ec73bcE588F309C1F65C406d2891C"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-vault-explorer": {
Expand Down
2 changes: 1 addition & 1 deletion addresses/sepolia.json
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@
"address": "0x7373C5b9610d43466395617c428eCAA5b47ac5AA"
}
],
"status": "ACTIVE",
"status": "DEPRECATED",
"version": "v3"
},
"20241205-v3-vault-explorer": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Contract } from 'ethers';
import { SignerWithAddress } from '@nomiclabs/hardhat-ethers/signers';
import { fp } from '@helpers/numbers';

describeForkTest('CompositeLiquidityRouter-V3', 'mainnet', 21336200, function () {
describeForkTest.skip('CompositeLiquidityRouter-V3', 'mainnet', 21336200, function () {
let task: Task;
let compositeLiquidityRouter: Contract;
let wethSigner: SignerWithAddress, alice: SignerWithAddress;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# 2024-12-05 - V3 Stable pool

> ⚠️ **DEPRECATED: do not use** ⚠️
>
> The stable pool was superseded by this [updated version](../../tasks/20250324-v3-stable-pool-v2/).

The original pool is still safe to use; V2 just includes new functionality.

Deployment of the `StablePoolFactory` for Balancer V3.
Pools from this factory use stable math, inspired by Curve stable pools, which is best suited for correlated assets.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { ONES_BYTES32, ZERO_ADDRESS } from '@helpers/constants';
import { bn, fp } from '@helpers/numbers';
import { StablePoolDeployment } from '../input';

describeForkTest('StablePool-V3', 'mainnet', 21336200, function () {
describeForkTest.skip('StablePool-V3', 'mainnet', 21336200, function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to know that we need to actively skip the tests inside the deprecated folder. I wonder if there's a way to automatically ignore these tests.

Copy link
Collaborator Author

@EndymionJkb EndymionJkb Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd have to special-case it in the scripts, which we generalized to find everything (making other things easier). It's possible, but since deprecation isn't that common, maybe it's not too onerous.

Technically they should all still work; I believe we skip them mainly to save CI time.

let task: Task;
let factory: Contract, pool: Contract;
let input: StablePoolDeployment;
Expand Down
Loading
Loading