Merge pull request #114 from bitmovin-engineering/fix/PW-20529/ssai-m…

…odule-crashes

[PW-20529] Fix ssai module crashes

CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Develop
 
+## v2.9.0
+
+### Fixed
+- collector crashes for certain SSAI workflows
+  https://bitmovin.atlassian.net/browse/PW-20529
+
 ## v2.8.0
 
 ### Added

collectorCore/ssaiService.brs

@@ -21,7 +21,7 @@ sub resetSsaiHelpers()
   m.currentAdMetadata = {}
   m.isFirstSampleOfAd = false
   m.adCustomData = {}
-  m.lastAdStartTimer = m.AD_TIMER_INIT_VALUE
+  m.lastAdStartTimer = invalid
   m.hasErrorBeenReportedForCurrentAd = false
 
   resetAdValues = {
@@ -40,7 +40,7 @@ function getSsaiAdSample()
 
   adSample.adType = m.AD_TYPE.SSAI
 
-  if m.lastAdStartTimer = m.AD_TIMER_INIT_VALUE
+  if m.lastAdStartTimer = invalid
     adSample.timeSinceAdStartedInMs = m.AD_TIMER_INIT_VALUE
   else
     adSample.timeSinceAdStartedInMs = m.lastAdStartTimer.TotalMilliseconds()

testing/source/tests/SsaiService.spec.bs

@@ -0,0 +1,39 @@
+namespace tests
+
+  @SGNode("collectorCore")
+  @suite("SsaiService")
+  class SsaiServiceTests extends rooibos.BaseTestSuite
+    protected override function beforeEach()
+      'bs:disable-next-line
+      initializeAnalytics()
+      'bs:disable-next-line
+      setupSsaiService()
+    end function
+
+    @describe("getSsaiAdSample")
+    @it("should set the elapsed time to -1 if no timer is active")
+    function _()
+      expectedTime = -1
+
+      'bs:disable-next-line
+      sample = getSsaiAdSample()
+
+      m.assertEqual(sample.timeSinceAdStartedInMs, expectedTime)
+    end function
+
+    @it("should set the elapsed time since adStart if an ad is in progress")
+    function _()
+      'bs:disable-next-line
+      adBreakStart()
+      'bs:disable-next-line
+      adStart()
+
+      'bs:disable-next-line
+      sample = getSsaiAdSample()
+
+      m.assertTrue(sample.timeSinceAdStartedInMs >= 0)
+    end function
+
+  end class
+
+end namespace