Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17715] Remove feature flag check from New Device Verification opt-out #13130

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Jan 29, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17715

📔 Objective

In #12880 we added the ability for users to opt out of New Device Verification.

In the original PR, the functionality was gated behind the new-device-verification feature flag.

This PR removes this feature from the larger feature flag scope, so that we can allow users to opt out prior to the feature being introduced.

See bitwarden/server#5342 for corresponding server PR.

📸 Screenshots

Screen.Recording.2025-01-29.at.12.41.22.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details88fc296c-5924-496b-aa0d-32c50f11d4e2

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.37%. Comparing base (1a97e86) to head (2f6d209).
Report is 89 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13130   +/-   ##
=======================================
  Coverage   35.37%   35.37%           
=======================================
  Files        3010     3010           
  Lines       91176    91174    -2     
  Branches    16996    16996           
=======================================
  Hits        32251    32251           
+ Misses      56419    56417    -2     
  Partials     2506     2506           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trmartin4 trmartin4 changed the title Remove feature flag check from opt-out [PM-17715] Remove feature flag check from New Device Verification opt-out Jan 29, 2025
@trmartin4 trmartin4 marked this pull request as ready for review January 29, 2025 17:45
@trmartin4 trmartin4 requested a review from a team as a code owner January 29, 2025 17:45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Changes look good.

@trmartin4 trmartin4 merged commit 3e988fa into main Feb 6, 2025
40 checks passed
@trmartin4 trmartin4 deleted the auth/pm-17715/remove-opt-out-from-feature-flag branch February 6, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants