Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17715] Remove feature flag from New Device Verification opt-out endpoint #5342

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Jan 29, 2025

🎟️ Tracking

bitwarden.atlassian.net/browse/PM-17715

📔 Objective

In #5264 we added the ability for users to opt out of New Device Verification.

In the original PR, the functionality was gated behind the new-device-verification feature flag. However, we want to let users enable this feature prior to the larger feature being released.

This PR removes the feature flag gate from the endpoint required to opt out of new device verification.

See bitwarden/clients#13130 for corresponding clients PR.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Remove feature flag from endpoint [PM-17715] Remove feature flag from New Device Verification opt-out endpoint Jan 29, 2025
@trmartin4 trmartin4 marked this pull request as ready for review January 29, 2025 17:49
@trmartin4 trmartin4 requested a review from a team as a code owner January 29, 2025 17:49
@trmartin4 trmartin4 requested review from rr-bw and Patrick-Pimentel-Bitwarden and removed request for rr-bw January 29, 2025 17:49
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.32%. Comparing base (a5b3f80) to head (f6f79ad).
Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5342   +/-   ##
=======================================
  Coverage   44.32%   44.32%           
=======================================
  Files        1483     1483           
  Lines       68418    68418           
  Branches     6173     6173           
=======================================
  Hits        30325    30325           
  Misses      36784    36784           
  Partials     1309     1309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Read the pr and description, sounds good.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details98f1c87f-9468-4eb7-ab38-ffb7b86c1b89

Great job, no security vulnerabilities found in this Pull Request

@trmartin4 trmartin4 merged commit f7d882d into main Feb 6, 2025
53 checks passed
@trmartin4 trmartin4 deleted the auth/pm-17715/remove-feature-flag branch February 6, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants