Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14419] At-risk passwords change password service #13279

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Feb 6, 2025

🎟️ Tracking

PM-14419

📔 Objective

Introduce a service to attempt to determine the well-known change password URL for a given login item. Use that service on the At-risk Passwords page that allows users to directly navigate to the change password page for their items that have been determined to be at-risk.

📸 Screenshots

Screen.Recording.2025-02-05.at.4.32.41.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@shane-melton shane-melton requested a review from a team as a code owner February 6, 2025 00:34
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.

Project coverage is 35.33%. Comparing base (9e6643f) to head (099c404).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...s/at-risk-passwords/at-risk-passwords.component.ts 41.66% 7 Missing ⚠️
.../services/default-change-login-password.service.ts 89.65% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13279      +/-   ##
==========================================
+ Coverage   35.32%   35.33%   +0.01%     
==========================================
  Files        3128     3130       +2     
  Lines       92601    92641      +40     
  Branches    16826    16830       +4     
==========================================
+ Hits        32709    32734      +25     
- Misses      57432    57446      +14     
- Partials     2460     2461       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Logo
Checkmarx One – Scan Summary & Detailsffbcda15-c774-403a-8f39-726e60e8072b

Great job, no security vulnerabilities found in this Pull Request

@shane-melton shane-melton force-pushed the vault/pm-14419/change-password-url-service branch from 56a1e02 to 5b04637 Compare February 6, 2025 19:10
nick-livefront
nick-livefront previously approved these changes Feb 11, 2025
this.launchingCipher.set(cipher);
const url = await this.changeLoginPasswordService.getChangePasswordUrl(cipher);

if (url == null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Would it be a better experience to hide the change button if the URL isn't available? At the moment if there is no URL the user doesn't have any feedback when clicking the button.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a trade off, on page load there would be a two requests flying for each of the ciphers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was the tradeoff to avoid spamming too many requests for large lists of ciphers. Though you do bring up a good point about there being a lack of feedback if there is no URL.

@sukhleenb What should the behavior be if we're unable to determine a change password URL and the item no longer as a URL associated? This should be pretty unlikely as items without URLs won't normally have tasks generated for them, but the cipher could technically have its URL removed after the task was created.

@shane-melton shane-melton force-pushed the vault/pm-14419/change-password-url-service branch 3 times, most recently from 2711418 to 50f0a82 Compare February 12, 2025 19:26
Base automatically changed from vault/pm-14421/at-risk-passwords-browser to main February 12, 2025 21:28
@shane-melton shane-melton dismissed nick-livefront’s stale review February 12, 2025 21:28

The base branch was changed.

@shane-melton shane-melton force-pushed the vault/pm-14419/change-password-url-service branch from 50f0a82 to 099c404 Compare February 12, 2025 21:36
@shane-melton shane-melton merged commit c67e6df into main Feb 13, 2025
95 checks passed
@shane-melton shane-melton deleted the vault/pm-14419/change-password-url-service branch February 13, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants