-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14419] At-risk passwords change password service #13279
[PM-14419] At-risk passwords change password service #13279
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13279 +/- ##
==========================================
+ Coverage 35.32% 35.33% +0.01%
==========================================
Files 3128 3130 +2
Lines 92601 92641 +40
Branches 16826 16830 +4
==========================================
+ Hits 32709 32734 +25
- Misses 57432 57446 +14
- Partials 2460 2461 +1 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
56a1e02
to
5b04637
Compare
apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.html
Outdated
Show resolved
Hide resolved
this.launchingCipher.set(cipher); | ||
const url = await this.changeLoginPasswordService.getChangePasswordUrl(cipher); | ||
|
||
if (url == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Would it be a better experience to hide the change
button if the URL isn't available? At the moment if there is no URL the user doesn't have any feedback when clicking the button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is a trade off, on page load there would be a two requests flying for each of the ciphers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this was the tradeoff to avoid spamming too many requests for large lists of ciphers. Though you do bring up a good point about there being a lack of feedback if there is no URL.
@sukhleenb What should the behavior be if we're unable to determine a change password URL and the item no longer as a URL associated? This should be pretty unlikely as items without URLs won't normally have tasks generated for them, but the cipher could technically have its URL removed after the task was created.
2711418
to
50f0a82
Compare
The base branch was changed.
…at-risk passwords tests
50f0a82
to
099c404
Compare
|
🎟️ Tracking
PM-14419
📔 Objective
Introduce a service to attempt to determine the well-known change password URL for a given login item. Use that service on the At-risk Passwords page that allows users to directly navigate to the change password page for their items that have been determined to be at-risk.
📸 Screenshots
Screen.Recording.2025-02-05.at.4.32.41.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes