Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15882] Remove unlock with PIN policy #13352

Merged
merged 14 commits into from
Feb 21, 2025
Merged

[PM-15882] Remove unlock with PIN policy #13352

merged 14 commits into from
Feb 21, 2025

Conversation

mzieniukbw
Copy link
Contributor

@mzieniukbw mzieniukbw commented Feb 11, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15882

📔 Objective

Added "Remove unlock with PIN" policy.
Server changes bitwarden/server#5388

📸 Screenshots

2025-02-21.16-13-25.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Logo
Checkmarx One – Scan Summary & Details0b729bae-5ac2-488d-a726-2c89be1822fc

Great job, no security vulnerabilities found in this Pull Request

# Conflicts:
#	apps/desktop/src/app/accounts/settings.component.ts
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 35.58%. Comparing base (f0ce877) to head (67eb1d1).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...le/organizations/policies/base-policy.component.ts 0.00% 5 Missing ⚠️
...fill/services/desktop-autofill-settings.service.ts 0.00% 2 Missing ⚠️
.../app/admin-console/organizations/policies/index.ts 0.00% 1 Missing ⚠️
...-console/organizations/policies/policies.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13352      +/-   ##
==========================================
+ Coverage   35.31%   35.58%   +0.26%     
==========================================
  Files        3138     3139       +1     
  Lines       92963    93022      +59     
  Branches    16890    16916      +26     
==========================================
+ Hits        32834    33103     +269     
+ Misses      57669    57385     -284     
- Partials     2460     2534      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mzieniukbw mzieniukbw requested a review from a team February 11, 2025 22:49
@mzieniukbw mzieniukbw marked this pull request as ready for review February 11, 2025 22:58
@mzieniukbw mzieniukbw requested review from a team as code owners February 11, 2025 22:58
jprusik
jprusik previously approved these changes Feb 12, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Auth changes looks good. Thank you for adding tests. Looked briefly over the other changes and they look good as well.

BTreston
BTreston previously approved these changes Feb 12, 2025
Thomas-Avery
Thomas-Avery previously approved these changes Feb 12, 2025
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice tests!

@mzieniukbw mzieniukbw dismissed stale reviews from jprusik, Thomas-Avery, and BTreston via b1d2d26 February 21, 2025 10:14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auth changes looks good! Thank you for posting a video.

@mzieniukbw mzieniukbw merged commit 78202e1 into main Feb 21, 2025
95 of 96 checks passed
@mzieniukbw mzieniukbw deleted the km/pm-15882 branch February 21, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants