-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15882] Remove unlock with PIN policy #13352
Conversation
Great job, no security vulnerabilities found in this Pull Request |
# Conflicts: # apps/desktop/src/app/accounts/settings.component.ts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13352 +/- ##
==========================================
+ Coverage 35.31% 35.58% +0.26%
==========================================
Files 3138 3139 +1
Lines 92963 93022 +59
Branches 16890 16916 +26
==========================================
+ Hits 32834 33103 +269
+ Misses 57669 57385 -284
- Partials 2460 2534 +74 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Auth changes looks good. Thank you for adding tests. Looked briefly over the other changes and they look good as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice tests!
b1d2d26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auth changes looks good! Thank you for posting a video.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15882
📔 Objective
Added "Remove unlock with PIN" policy.
Server changes bitwarden/server#5388
📸 Screenshots
2025-02-21.16-13-25.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes