Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15882] Added RemoveUnlockWithPin policy #5388

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mzieniukbw
Copy link
Contributor

@mzieniukbw mzieniukbw commented Feb 11, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15882

📔 Objective

Added RemoveUnlockWithPin policy.
Client changes bitwarden/clients#13352

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.30%. Comparing base (bde11da) to head (da863ac).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/AdminConsole/Enums/PolicyType.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5388      +/-   ##
==========================================
- Coverage   44.30%   44.30%   -0.01%     
==========================================
  Files        1497     1497              
  Lines       69212    69213       +1     
  Branches     6241     6241              
==========================================
  Hits        30665    30665              
- Misses      37224    37225       +1     
  Partials     1323     1323              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mzieniukbw mzieniukbw marked this pull request as ready for review February 11, 2025 09:51
@mzieniukbw mzieniukbw requested a review from a team as a code owner February 11, 2025 09:51
@mzieniukbw mzieniukbw requested review from BTreston and a team February 11, 2025 09:51
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Logo
Checkmarx One – Scan Summary & Details41738e93-f597-4f07-8df4-ade2cbb7cf58

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants