Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlazingMQ Client/Broker Protocol #167

Merged
merged 1 commit into from
Dec 8, 2023
Merged

BlazingMQ Client/Broker Protocol #167

merged 1 commit into from
Dec 8, 2023

Conversation

quarter-note
Copy link
Contributor

Issue number of the reported bug or feature request: #28

Describe your changes
Attempting to document the client/broker protocol in BlazingMQ. At a high level, document will cover three areas:

  • BlazingMQ wire protocol
  • Message exchanges b/w client and broker
  • Guidelines and recommendations for client library implementation

Replaces #95

@quarter-note
Client broker protocl
65c79b0 
Signed-off-by: Ankur Saxena <[email protected]>
@quarter-note quarter-note requested a review from a team as a code owner December 7, 2023 20:54
@quarter-note quarter-note mentioned this pull request Dec 7, 2023
Closed
@pniedzielski
Copy link
Collaborator

For review, what are the differences between #95 and this one? Viz. does this include all the review comments from there already applied?

@quarter-note
Copy link
Contributor Author

For review, what are the differences between #95 and this one? Viz. does this include all the review comments from there already applied?

Yes, this one includes all the feedback. I had to close #95.. was having some trouble signing off commits there.

@pniedzielski pniedzielski self-requested a review December 8, 2023 21:50
pniedzielski
pniedzielski approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick scan of the document again, contains all changes from previous PR so I'm confident about it.

@quarter-note quarter-note merged commit 2b68c90 into bloomberg:main Dec 8, 2023
7 checks passed
@quarter-note quarter-note deleted the docs/client-broker-protocol branch December 8, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pniedzielski pniedzielski pniedzielski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quarter-note @pniedzielski