-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlazingMQ Client/Broker Protocol #95
BlazingMQ Client/Broker Protocol #95
Conversation
78298ca
to
35b49a3
Compare
Hi @sgalichkin Could you review the document? I am asking you to review since you are familiar with quite a bit internal SDK details including the wire protocol. Thanks. |
Personally, I really missed the detailed layout of all the messages, especially the binary ones. For example, if you look at the Kafka protocol documentation, you will see a schema of all messages, including their types, order, purpose, changes from version to version, and so on. I have to reverse-engineering your Java SDK a lot to understand how to encode binary messages. Maybe when I'm done with my SDK, I'll make a pull-request with the binary message schema added. Anyway thanks a lot for your work, for the first version of the protocol documentation it is very good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea typo search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly proofreading comments. In a few places, it seems like some fairly important details are hidden deep into the document, which may benefit from having them lifted out earlier. See comments for details.
I have applied commit suggestions. Will address general comments later. Thanks of reviewing @678098 and @pniedzielski |
Signed-off-by: Ankur Saxena <[email protected]>
Signed-off-by: Ankur Saxena <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
7e8b9e3
to
bc432a7
Compare
Co-authored-by: Patrick M. Niedzielski <[email protected]> Signed-off-by: Ankur Saxena <[email protected]>
Co-authored-by: Patrick M. Niedzielski <[email protected]> Signed-off-by: Ankur Saxena <[email protected]>
Co-authored-by: Patrick M. Niedzielski <[email protected]> Signed-off-by: Ankur Saxena <[email protected]>
Co-authored-by: Patrick M. Niedzielski <[email protected]> Signed-off-by: Ankur Saxena <[email protected]>
Signed-off-by: Ankur Saxena <[email protected]>
bc432a7
to
de7f153
Compare
Replaced w/ #167 |
Issue number of the reported bug or feature request: #28
Describe your changes
Attempting to document the client/broker protocol in BlazingMQ. At a high level, document will cover three areas: